commit | a0ae95f38a90834a339deb333ac89682129619ed | [log] [tgz] |
---|---|---|
author | Claire Chambers <clchambers@microsoft.com> | Tue Nov 21 19:30:17 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Nov 21 20:08:26 2023 |
tree | 65a243ddec24af4e577470be7774fcd1b0b0a307 | |
parent | 51aedacd3064ca56249d3917c44dad5968222a10 [diff] |
[CompositeClipPathAnimations] Fix crash for animation fill forward This CL fixes a crash that occurred when animation-fill-mode is set to forwards. This crash occurs because invalidating the paint property data on the animated element is contingent upon the clip path data actually changing, which might not happen if the system has had a frame on main thread recently enough that the clip path hasn't changed - or if the animation is using a slow or steps() timing function. Without updating this data, the layout object with the animation will still have a mask based clip, but without an active animation. Because mask based clip isn't designed for shape clip paths, a crash results. This change makes a change from having a composited clip animation to not having one unconditionally invalidate paint properties for a given LayoutObject, ensuring mask based clip stops being used when it is no longer applicable. Bug: 1497795 Change-Id: I1b2958c84607f2fa8bbe37fe7e860ef47a364fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5003331 Commit-Queue: Claire Chambers <clchambers@microsoft.com> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1227521}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!