commit | 12e68908ef166e690be17a7db9eda0df925ee0ee | [log] [tgz] |
---|---|---|
author | Morten Stenshorne <mstensho@chromium.org> | Tue Nov 14 19:58:50 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Nov 14 20:46:43 2023 |
tree | 9c6b593e17ae5a3f4a1315ef3c6f71845799b86a | |
parent | b97683e7f3bd2ac4246abd11c67bab5cfb891c57 [diff] |
Once content is added to a builder, break as normally. If the RequiresContentBeforeBreaking flag was set when initializing the fragment builder, it was never set to false again. This was generally unproblematic, since it only affected last-resort break opportunities, which generally only occur at the beginning of a fragment (e.g. between a container and its first child). However, in flex layout there may be a last-resort break opportunity before any flex item that's flush with its flex line, because that is seen as having no container separation. Therefore, reset the RequiresContentBeforeBreaking flag once a child has been added to the builder. That in itself is a simple fix, in NGBoxFragmentBuilder::AddChild(). The rest of this CL is about keeping this mechanism working for out-of-flow positioned elements. We now need to check the RequiresContentBeforeBreaking state exactly when the out-of-flow positioned element is found in the box tree, not when it's being laid out. Doing it later, in NGOutOfFlowLayoutPart, is now too late, since the flag may have been reset in the meantime, which would prevent us from forcing OOFs to stay in the current fragmentainer when they should. So store it directly in NGLogicalOutOfFlowPositionedNode when creating it. Since these objects bubble up the parent chain as physical fragments, NGPhysicalOutOfFlowPositionedNode also needs to store this. Storing it in NGContainingBlock is no longer necessary, on the other hand. css/css-break/tall-content-inside-constrained-block-006.tentative.html is a test for this. Bug: 1500947 Change-Id: I3b60239b0bdac82477748b3e0a99daf074d7246d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5029777 Reviewed-by: Alison Maher <almaher@microsoft.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1224475}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!