commit | 9a4dbf80eb628c8d3b999fcae8d5b9dfeeaec910 | [log] [tgz] |
---|---|---|
author | sisidovski <sisidovski@chromium.org> | Fri Nov 17 08:53:04 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri Nov 17 09:10:16 2023 |
tree | 78b5cc091f88df1b919f40573174976505898e34 | |
parent | 93a913f78f8eb3fcfd2680f11e82a0b7c485fcd2 [diff] |
Refactor WPTs for SW Static Routing API Before this CL, registered router rules are global across tests and those are set all at once. That makes adding new tests difficult because by having that, we always need to mind if the existing registered rules affect or not, also it's not strucutured. This CL introduces the functionarity to add arbitrary rules which you'd like to test based on string based key. By passing the keyname to `iframeTest()` from the test code, the SW registers corresponding rules which are defined in router-rules.js. To achieve that, this CL splits router rules and SW code. SW decides the selected router rules based on the key, and the key is passed via the query parameter from test code. To import router rules from SW, SW is registered with type module. This CL will stop passing the string as an input to `urlPattern` condition. This was kind of an ad-hoc approach to address changes between M116 and M117. The current tests only checks whether the rule matched or not based on the urlPattern input, and not testing all cases of the urlPattern input (string, URLPatternInit etc). So it's fine to be changed to URLPatternInit. We will add other cases in a follow-up anyway. Bug: 1371756 Change-Id: I1d1ee92c7a022e5fe3698fe9dffd960658cdec76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5039073 Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Shunya Shishido <sisidovski@chromium.org> Cr-Commit-Position: refs/heads/main@{#1225965}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!