commit | eb5d95c1218670e7e0a090577b86b1355b997b73 | [log] [tgz] |
---|---|---|
author | Dan Clark <daniec@microsoft.com> | Wed Nov 22 17:53:03 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Nov 22 18:11:15 2023 |
tree | 14e000c3f01961608c286be4424b200553ffac7d | |
parent | 123dd364e65bc553805fb1b713122a0cc25be0d9 [diff] |
[EditContext] Ensure that ExecutionContext of the associated element is used Currently if an author tries to associate an EditContext with an Element in a document that's different from the document where it was constructed, the EditContext will make the associated element editable but not capture text input. The reason is that in `EditContext::Focus()`, the call to do `GetInputMethodController().SetActiveEditContext(this)` is getting the InputMethodController for the ExecutionContext that the EditContext was constructed with, not the InputMethodController for the document the EditContext is now associated with. So to the InputMethodController that ends up receiving the text input, it looks like there is no active EditContext. Fix this by updating the EditContext's ExecutionContext whenever an associated element is set. An alternative considered was to have EditContext no longer store the ExecutionContext directly at all and instead always get it from the associated element. However there are some cases where this is problematic. For example when DispatchTextFormatEvent is called immediately before DispatchCompositionEndEvent, the EditContext could be detached from its element in the textformatupdate handler, which would then cause problems in DispatchCompositionEndEvent since it uses the ExecutionContext via the DomWindow() call. Bug: 1468441 Change-Id: Ic68d57f360a2d1d72fdc786ef9c4ea0d028ce9ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5046158 Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Anupam Snigdha <snianu@microsoft.com> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1228072}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!