commit | eb05bf88d9520f090346f04c243e20c9b4a8d458 | [log] [tgz] |
---|---|---|
author | Masayuki Nakano <masayuki@d-toybox.com> | Tue Dec 05 02:39:13 2023 |
committer | moz-wptsync-bot <wptsync@mozilla.com> | Tue Dec 05 09:39:30 2023 |
tree | 7d44711fc9e25eab59fabf22952ea917a07ba9e5 | |
parent | 02e3e674eb4b8003b4458e8877e862bf910a9395 [diff] |
Make `IMEStateManager` recreate `IMEContentObserver` if the active one is not observing editable content of focused element The test case is a special case that changes focused element from a text control to an editing host. Therefore, without a focus change, focused editor is changed from a `TextEditor` to `HTMLEditor`. At this time, `IMEContentObserver` needs to switch the observing target from the anonymous content if `<input>` to children of it. However, the editable content becomes completely changed without a focus change in the DOM. Therefore, `IMEStateManager` needs to synthesize a fake focus move for IME. Therefore, this patch make `IMEStateManager` recreate `IMEContentObserver` if active one is not observing editable content for the focused element under "current" conditions at checking it. (When `IMEContentObserver` is being destroyed, it sends "blur" notification to IME and the new `IMEContentObserver` instance posts "focus" notification with all editable content data. I.e., recreating `IMEContentObserver` generates a fake focus move from IME point of view.) Additionally, there is the opposite case, that is, editing host of an `<input>` whose type is not a text control may become a text control. Therefore, this adds new WPTs to check the handler is the text editor for the text control or the HTML editor. The tests passed on Firefox and Chrome at least. FYI: I guess that in this case, we need to kick `focus` event listener of the `HTMLEditor`, but anyway, users cannot change the content because it's the case that an atomic content is the editing host. Therefore, I don't touch about that in this patch. Differential Revision: https://phabricator.services.mozilla.com/D193262 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1863759 gecko-commit: 39486bb8305a2e3128c6ecd97d33378744922507 gecko-reviewers: smaug, m_kato
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!