| commit | cbdf2ef3751180f4f7b144565082261662f1d024 | [log] [tgz] |
|---|---|---|
| author | David Awogbemila <awogbemila@chromium.org> | Wed Dec 13 16:02:35 2023 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Dec 13 16:22:35 2023 |
| tree | 70783e13500786b119df74c1e2f59e963c2c65f2 | |
| parent | 83b10e015ad6b50100cab9dcca1f60d28eb18ac6 [diff] |
Some fixes for SnapEvents tests
This patch addresses failures that occur when the affected tests are
run against the full chrome binary (not just content_shell) with
chromedriver.
Summary of the changes:
- chromedriver throws the error "Action action_sequence failed" when
the inputs to test_driver.Actions.pointerMove are not integers so
this patch rounds these inputs to whole numbers.
- chromedriver seems to require the "origin" parameter to
test_driver.Actions.scroll to ensure the scroll is directed at the
scroller.
- Element.offset{Top, Left} are integers[1] and
Element.scroll{Top, Left} may also be rounded, so this patch uses
assert_approx_equals (instead of approx_equals) with a tolerance of
1px. This isn't related to chromedriver but it does affect
snapchanged-on-programmatic-root-scroll which uses a percentage (40vh)
of the size of the scroller (the window) which can vary and lead to
off-by-one differences.
[1]https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/offsetLeft#:~:text=An%20integer
Change-Id: I86f9bbbc580d31be56e78f93edc671b6fe46c478
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5097343
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1236953}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!