| commit | a1129b1a738fbcb6324b8518a6d64714d38babd4 | [log] [tgz] |
|---|---|---|
| author | Ian Kilpatrick <ikilpatrick@chromium.org> | Tue Dec 12 18:29:00 2023 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Dec 12 18:39:39 2023 |
| tree | 6e533c445e9264dbdae395794b496d923a4c1088 | |
| parent | 7bec9b28c5e61b19ef9c58dc7435293e3ca66493 [diff] |
[layout] Respect align-self/justify-self for abspos elements.
This fixes the bug that we weren't respecting align-self/justify-self
for abspos elements with both insets set.
Instead of just using the containing block "start" inset bias when
both insets are set - look at the value of align-self/justify-self
(see logic in GetAlignmentInsetBias).
Tests are validating the following:
- {align,justify}-self-*.html -> validates the correct position with
different writing-mode combinations and *-self keywords. (Tests the
complex logic in GetAlignmentInsetBias).
- safe-{align,justify}-self-*.html -> validates the safe/unsafe
behaviour with different writing-mode combinations, and "safe end".
(Tests the clamping logic in ComputeInsets).
- stretch-intrinsic-size-*.html -> validates the correct aspect-ratio
handling for stretching one axes, and the size being reflexed in
the opposite axis, with different writing-mode combinations. (Tests
the logic in ComputeOof*Dimensions and the replaced logic in
out_of_flow_layout_part.cc).
- table-{align,justify}-self-stretch.html -> validates correct table
stretching behaviour, and that tables still respect their implicit
min-intrinsic size constraint.
Placed behind blink flag: LayoutAlignForPositioned
Bug: 226252
Change-Id: Ide7cc3cf0fa00d431c8ea1ca24192a5643f18310
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5086490
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1236432}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!