commit | 62e577ff5f74405dc79a995505369ca1c343d504 | [log] [tgz] |
---|---|---|
author | Michael Lippautz <mlippautz@chromium.org> | Thu Dec 14 20:00:43 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Dec 14 20:23:55 2023 |
tree | de290fd4779c65cc2db8edb9fbf7f2d81b054f83 | |
parent | 58338f399b168946aa4861ff1d8777bb1015f7d9 [diff] |
DOMWindow: Set wrapper reference to global proxy object The JS global proxy object already points to the {Local,Remote}DOMWindow via internal field. Make DOMWindow::main_world_wrapper_ point to the global proxy object as well. Avoid using the already existing AssociateWithWrapper() methods as they require that a context is properly set up. {Local,Remote}WindowProxy's global_proxy_ field becomes a regular traced reference without setting up the class id. The GC treats it the same way for liveness but heap snapshot generation would not consider it as a candidate to merge nodes with a JS object as it's not ScriptWrappable's::main_world_wrapper_. This way Wrappable/Wrapper pairs (represented by ScriptWrappable/V8 objects) are properly set up in the entire codebase and may on a high-level considered as one object or "entity". This allows heap snapshot generation to merge the nodes without considering the class id state on the reference. Ultimately, this allows us to get rid of the class id eventually and speed up all TracedReference creation. Delete WPT test: performance-timeline/tentative/performance-entry-source-deleted-frame.html Rationale: - The test was added to check that a PerformanceEntry does not leak Window objects via its source property when PerformanceEntry objects are stashed away to be consumed later. - The test merely checks that we return a null Window for a detached Window. This is not what it was added for. - The test fails for FF and Safari [1] - Writing this test properly is really hard: The JS wrapper is already materialized in the iframe via `performance.mark()`. Thus accessing `childEntry` from the main frame leaks the other iframe via the JS wrapper constructor (that points to its context). In order to avoid this, one must stash the Window itself in a weak ref, perform GC at the event loop, and then check the weakref. Performing GC at the event loop is not supported in WPT as of today. [1] https://wpt.fyi/results/performance-timeline/tentative?label=master&label=experimental&aligned&q=performance-timeline%2Ftentative%2Fperformance-entry-source-deleted-frame.html Tests: DevTools frontend e2e memory/* Bug: chromium:1218404 Change-Id: I4e3273c6ca7da8e3241b4f9ac78c76932c52bce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2953842 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#1237676}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!