| commit | 6374bc3642b37c3ef72adb029b99d5536fb9c914 | [log] [tgz] |
|---|---|---|
| author | David Bokan <bokan@chromium.org> | Fri Dec 15 15:47:28 2023 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri Dec 15 16:08:59 2023 |
| tree | ece5e3403355a8107f02e26cf649d2d79f541670 | |
| parent | 89a05982b5f1f0c4f1a7674033a294046f36a56b [diff] |
vt: Fix CHECK trying to merge anonymous block This CHECK would trip as changing listStylePosition triggers a layout tree reattachment[1]. This causes the documentElement's LayoutObject to be removed which happens before the LayoutViewTransitionRoot. LayoutViewTransitionRoot represents the snapshot containing block and doesn't have an associated Node, making it "anonymous". When documentElement's object is removed, it removes itself from the parent LayoutView. Since LayoutViewTransitionRoot is the only remaining child, LayoutView tries to hoist its contents onto itself in CollapseAnonymousBlockChild[2] since anonymous blocks are typically created artificially to host non-block content in a block flow. This tries to add the ::view-transition LayoutObject to LayoutView which trips the CHECK that LayoutView doesn't yet have a LayoutViewTransitionRoot, since doing so will add one. LayoutViewTransitionRoot is anonymous but doesn't want to have this merging/collapsing property so this CL opts it out of that behavior. [1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/style/computed_style.cc;l=372;drc=a9187270cee16e9adf8ba3b0286ab80694448a70 [2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/layout/layout_block_flow.cc;l=271;drc=0e6e802410c16813e03bd2884f8e7f7889b87783 Bug: 1505249 Change-Id: Ifcd2e3b0e54fe9bc84a741142196031ad566c626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5122373 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1238076}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!