| commit | cdafbec95bd598d0bd109e1210053dfe664e6901 | [log] [tgz] |
|---|---|---|
| author | Thomas Broyer <t.broyer@ltgt.net> | Tue Feb 06 13:22:53 2024 |
| committer | GitHub <noreply@github.com> | Tue Feb 06 13:22:53 2024 |
| tree | fee95663faa36c90d522976a11286e168b8cc3c5 | |
| parent | e3f0f309963f48c0f7a4433c1cb31d8e013400a0 [diff] |
Improve reflected attribute tests (html/dom/reflection.js)
* Fix reflection tests wrt valueOf
Without a toString:null in test values that are objects
with a valueOf method, the DOM attribute would actually
be set to "[object Object]" without ever calling the
valueOf method (effectively turning those tests into
behaving exactly the same as the {"test": 6} ones).
Most existing tests were passing because the implemented
algorithms would actually compute a WRONG expected value.
The only test that doesn't compute the expected value
("double") won't actually run because all reflected IDL
attributes of type "double" have custom getters.
Fixes #44315
* Fix reflection tests wrt -0 for "double" attributes
Setting -0 to the IDL attribute will set the DOM
attribute to "0" (per ECMAScript's ToString, from the
rules for the the best representation of a number as
a floating point number), and the rules for parsing
flowting-point number values won't ever turn that "0"
into a -0 value.
This test value is never actually being used though,
as all the reflected attributes of type "double" have
custom getters.
* Add a few more reflection tests around whitespace for numeric types
Specifically leading non-ASCII whitespace following leading
ASCII whitespace (should be rejected), and trailing non-ASCII
whitespace (should be ignored)
* Add a few more numeric values to reflection tests
Specifically "+" and "-" to exercise all possible code
paths of failures.
* Add exponential notation to reflection tests of double values
* Implement "limited double" in reflection tests
* Implement the reflect algorithm for doubles
This should make it easier to extend tests with more values.
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!