commit | effd91d0c3ea64f8c75f7fe0714d98f96a78dc2a | [log] [tgz] |
---|---|---|
author | Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> | Thu Feb 08 18:49:17 2024 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Feb 08 19:13:40 2024 |
tree | 3a7cc1001327d16f93fb548122aa77a323bbee8b | |
parent | 11f539a39cc30d82c4a89e134cc2d9495a2ee147 [diff] |
sensors: Make virtual sensors always remember and report the latest reading This concerns a discussion that started in https://crrev.com/c/5249795: the idea is to make a virtual sensor leak fewer implementation details, such as the fact that the current reading is lost when the sensor is deactivated. This should not be observable from e.g. a web test, as there is nothing mandating that this happen in the first place. From an API user's perspective, once a reading is added to a virtual sensor (including if this happens before a Sensor instance is created in Chromium) it remains present until it is replaced by another one, even if the sensor is stopped and reactivated. This is complemented by the behavior added in https://crrev.com/c/5245506, in which any pending reading (or, with this CL, the latest reading) is stashed until it can be published. In other words, a VirtualPlatformSensor now respects the following two invariants: 1. Once a reading is set, it will remain set until it is replaced with another reading. 2. Said reading will be added to the shared buffer and clients will be notified whenever the sensor is activated. While here, revert the part of https://crrev.com/c/5245506 that renamed PlatformSensor::IsActiveForTesting() to is_active(), as this is no longer needed. Bug: 1520919, 1506995 Change-Id: I205432cbf196376f67a6bc1c84d69302ffe739ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5272509 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Raphael Kubo Da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/main@{#1258046}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!