| commit | f74d912ea24c92c020b49f5f84c8c1e69425cfbf | [log] [tgz] |
|---|---|---|
| author | Morten Stenshorne <mstensho@chromium.org> | Fri Feb 16 08:09:32 2024 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri Feb 16 08:26:53 2024 |
| tree | 5252364df8cd397cedcf3bb6dd5c37798b312d01 | |
| parent | f6f118de16681fc1586f265c2ea7bea98fc7dec9 [diff] |
Remove old OOF fragmentation spanner-awareness code. This was needed back when OOFs didn't affect column balancing. We would in some cases have to manually create additional fragmentainers when starting layout of an OOF (with a sufficiently large block-offset) *after* the spanner, even though the OOF was defined before the spanner. We no longer do that, now that OOFs affect column balancing. The code that's now removed had no effect (as far as I can tell) in non-nested multicol, since we always make room for OOFs before the spanner. However, it did do something in nested multicol with spanners, because we'll fail to make enough room for OOFs in cases where they would cross an outer fragmentainer boundary. What this code did was wrong in such cases anyway. It would push additional fragmentainers below the spanner, and not set the right block-size, resulting in overflowing the outer fragmentation context in the block direction. By removing this code, we'll now just create additional fragmentainers at the same block-offset as the last one, progressing in the inline direction. This is the best we can do (and what we did in all other cases, anyway), since we don't support creation of additional outer fragmentainers for OOFs. Two unit tests have to be updated, because of the above. One of them now behave correctly, while the other one still isn't quite there. Add a web test for it as well. By removing this code, UpdatedFragmentainerOffset() ended up only adding fragmentainer_progression, if it was a new fragment. Just remove the function and do the job at the call site instead. In LayoutOOFsInFragmentainer(), if we find the last fragmentainer *before* calling GetFragmentainerConstraintSpace(), we won't have to do the same job in there, since GetFragmentainerConstraintSpace() no longer needs to know whether it's a new fragmentainer or not. This doesn't really fix crbug.com/40775119 , but it does improve the rendering of the demo there. Bug: 40775119 Change-Id: I98094ee5da428a190355d72da8eff0f901b2b874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5300220 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1261525}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!