commit | ba9ab536564c0a954cabc73c5ae36772fffc029e | [log] [tgz] |
---|---|---|
author | Anders Hartvoll Ruud <andruud@chromium.org> | Thu Mar 21 13:42:00 2024 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Mar 21 14:31:13 2024 |
tree | e7ce22c318110f4cb4efee0dbda8610a326c4b9d | |
parent | a2b4ffc1d921d0137b1371bd6caa53a87dd2bd3b [diff] |
[anchor] Support try-tactic flips for self-alignment properties The self-alignment properties are a bit different from the other properties that require adjustment. For insets and sizes, a value transformation (e.g. anchor(right) becoming anchor(left)) is always accompanied by a corresponding property transformation (e.g. left becoming right), but for self-alignment properties we need value transformation within the same property. E.g. justify-self:start under flip-start becomes justify-self:end (no change in property). Therefore these properties are always present in the try-tactics layer. Also, it's worth noting that justify-self accepts the 'left' and 'right' keywords, but align-self does not accept 'top'/'bottom'. This means we can't just naively grab-and-flip the value of the other property for flip-start: we need to convert left/right to logical to avoid giving align-self an invalid value. Since the exact details of what left/right should become in this case is non-obvious (and not specified) [1], I've avoided this case in the WPT for now. Bug: 40279608 [1] https://github.com/w3c/csswg-drafts/issues/10049 Change-Id: I8fa675a0be3f3c50ca73b4b628583765e252b032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5383077 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1276166}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!