| commit | 039e0b75a1457090a6d0aed1cb10b8997ee8d284 | [log] [tgz] |
|---|---|---|
| author | Anders Hartvoll Ruud <andruud@chromium.org> | Thu Apr 11 19:21:08 2024 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Apr 11 20:06:34 2024 |
| tree | 882379dc2eed16c1d3c2a2173c836c9f21f68908 | |
| parent | 9f1cfd6824f166bd08d46c061be9e507d6bb45a7 [diff] |
[anchor] Invalid anchor()/anchor-size() without fallback becomes IACVT A recent CSSWG resolution changed the "missing fallback behavior" from always returning 0px, to instead behaving as invalid at computed- value time [1]. This is the first time a calc() result can become IACVT, so we need to make some adjustments for this to be possible. The approach in this CL does not have the best performance, but it gets the job done without a massive calc()/ApplyValue code refactor. In StyleCascade, at the place we currently resolve var() substitutions, we also check if we need to "resolve" any CSSMathFunctionValues into IACVT (unset). This is required when the CSSMathFunctionValue contains anchor() or anchor-size() functions without fallbacks, and when evaluating any of those produces no result. In order to figure this out, we have to actually evaluate the queries. This unfortunately means that we evaluate the queries twice for the time being: once for the validity check, and again for the real calculation immediately after. We had an existing function InvolvesAnchorQueries which traversed the expression tree in full every time, but I changed this to instead return a boolean stored on the CSSMathExpressionNode itself. Since the approach is identical to HasComparisons, I renamed to HasAnchorFunctions for consistency. The reason for this change is to avoid an expensive InvolvesAnchorQueries check for every CSSMathFunctionValue seen in the cascade. Evaluating calc() values with anchor*() inside, even to just check for validity, needs to happen on scoped values (CSSValue::IsScopedValue). Previously, we'd scope-ify the value immediately before ApplyPhysical- Property (which ultimately evaluates any anchor*() functions), but now we can risk evaluating anchor* () sooner than that. Therefore I had to split out the tree-scope-ensuring code, and use that during the Resolve step for the CSSMathFunctionValue. Finally, the static StyleCascade::Resolve function, which is an API for resolving arbitrary CSSValues against the computed values of some element, used kAuthor (by arbitrary choice) as the value's origin. This conflicts with EnsureScopedValue's reasonable assumption that any cascade entry with kAuthor is backed by an actual MatchResult entry, hence I changed this to kNone. This part of the CL should be a "no behavior change" vs the existing code. [1] https://github.com/w3c/csswg-drafts/issues/10005 Bug: 333720826 Change-Id: I7e02beb44981fd47a30981ef808af3ec18c1950a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5447517 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Daniil Sakhapov <sakhapov@chromium.org> Cr-Commit-Position: refs/heads/main@{#1286010}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!