commit | 2464208d7ebb636496d1bc92f24a007f2c85f75c | [log] [tgz] |
---|---|---|
author | Anders Hartvoll Ruud <andruud@chromium.org> | Wed Apr 17 20:18:32 2024 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Apr 17 21:16:45 2024 |
tree | bb6f85428e76a81d10f8628ec7b6ab67160a5bc3 | |
parent | 0452ba6f627cf0d8f3e76a7b75cb0fad178cd57d [diff] |
[anchor] Delay ::backdrop updates during interleaving Elements in the top layer appear early in the layout tree, and so we get the call to UpdateStyleForOutOfFlow for ::backdrop *before* the call to UpdateStyleForOutOfFlow for the originating element. This is problematic, because the second call to UpdateStyleForOutOfFlow (for the originating element) may also recalc the style of the ::backdrop pseudo-element (which already had its UpdateStyleForOutOfFlow call). The result is a computed style for ::backdrop where all anchor*() functions are invalid. This issue is currently masked by a combination of CL:5447517 and Issue 330758160: the second call to UpdateStyleForOutOfFlow recalculates the style, but doesn't invalidate anything. Since the computed value of an invalid anchor*() is auto (CL:5447517), getComputedStyle() grabs the value from the box, which is still correct due to missing invalidation. However, if we add explicit 0px fallbacks to the anchor() functions within ::backdrop, getComputedStyle() won't ask the box, and we see that the computed values are in fact wrong. This problem is similar to the issues with had with ::backdrop for Container Queries, so we can solve this the same way: by delaying the updates to ::backdrop using PostStyleUpdateScope, and do another round if needed. Note: The new test (position-try-backdrop.html) also passes without this CL. The anchor attribute test no longer passes without this CL however, due to the addition of explicit 0px fallbacks (which aren't supposed to be taken). Bug: 335052779 Change-Id: I48f33568e172983be28264a982b5e04c22e16001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5458187 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1288929}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!