commit d05eb2edd3e0b918ba56c3e9735b5594ea3d8b25
author Theo Cristea <theocristea@google.com> Thu Apr 25 12:42:55 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Apr 25 12:42:55 2024
tree 63a9478d7af168cb468f8669820f34332d030d42
parent 70a200454d89ae9d3fccf19998587f606407c482

Try to fix and debug flaky Popup Controller interactive tests

The tests are failing very rarely due to timeout in `RunUntil()`. One
possibility is that the `RunUntil()` condition is never checked, so the
CL adds a counter to see how many times the condition is checked.

The timeout value cannot be printed because it is private to the
RunLoop() class:
https://source.chromium.org/chromium/chromium/src/+/main:base/run_loop.h;l=285;drc=6da5a07c08b33596d9ec990e1a6d5041a03c79f1

I logged the timeout locally, and its value is 30 seconds.

Moreover, this CL deletes a redundant line which attempts to show the
Autofill Popup again (after it has already been shown once). This cannot
break the code, but maybe it can help the popup to be shown before the
timeout.

Bug: 335574482
Change-Id: I44209f2417c9aba01a1a3319aadb9da14099675c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5488081
Reviewed-by: Jan Keitel <jkeitel@google.com>
Commit-Queue: Theo Cristea <theocristea@google.com>
Cr-Commit-Position: refs/heads/main@{#1292392}