)]}'
{
  "commit": "5fd368aaf91c25a5fb8e4e214acb09fda36acdaa",
  "tree": "538c66c66c9aae26ea0ff866b6798947476ecb2a",
  "parents": [
    "456204eaefe45950e9f082e67af83fa13a70aae6"
  ],
  "author": {
    "name": "Igor Nazarov",
    "email": "i.nazarov@samsung.com",
    "time": "Wed Jul 30 14:45:55 2025"
  },
  "committer": {
    "name": "Angle LUCI CQ",
    "email": "angle-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Thu Jul 31 12:08:43 2025"
  },
  "message": "Replace Surface::getWidth/Height() with getSize()\n\nMost places in the code use both `getWidth/Height()` methods at the same\ntime. On some back-ends it is more optimal to have single method.\nFor example, `WindowSurfaceWGL` first uses `GetClientRect()` Win32 API\ninside each method to then calculate width and hight in each method,\ncausing repeated `GetClientRect()` call.\n\nThe only place where only one of the methods may be used is from\n`SurfaceImpl::getUserSize()` when one of the parameters is `nullptr`,\nwhich is only possible from `QuerySurfaceAttrib()` function. This\nmethod is rewritten to use new `getSize()` method and then use whatever\ndimensions is requested by the caller. This may cause\n`QuerySurfaceAttrib()` inefficiency on some back-ends that get width and\nheight of the surface differently (`SurfaceEGL` for example). In such\ncases `getUserSize()` is overridden to avoid returning a dimension\nwhich is not required.\n\nAfter this change all places in the code that previously used both\n`getWidth/Height()` methods (like `Surface::getAttachmentSize()`) will\nbe more efficient. The `QuerySurfaceAttrib()`, on the other hand, will\nhave slightly more overhead on back-ends where base\n`SurfaceImpl::getUserSize()` method is used, which only happens on\nback-ends with trivial `getSize()` implementation.\n\nBug: angleproject:397848903\nChange-Id: I4a22701a1e62ee4e7d07e77cac5b388050d98e4d\nReviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6802440\nReviewed-by: Shahbaz Youssefi \u003csyoussefi@chromium.org\u003e\nCommit-Queue: Igor Nazarov \u003ci.nazarov@samsung.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "fe5cc2a71a715e5fe73721b873e536425fcb0161",
      "old_mode": 33188,
      "old_path": "src/libANGLE/Surface.cpp",
      "new_id": "0fdeae24589efb19cbe9268b6406c379ea262451",
      "new_mode": 33188,
      "new_path": "src/libANGLE/Surface.cpp"
    },
    {
      "type": "modify",
      "old_id": "483ea020ccf1ab29bedde20d6303b9e019df0c89",
      "old_mode": 33188,
      "old_path": "src/libANGLE/Surface.h",
      "new_id": "d11702fe298ab905db12310f26b3a4f385d3cc5e",
      "new_mode": 33188,
      "new_path": "src/libANGLE/Surface.h"
    },
    {
      "type": "modify",
      "old_id": "e356c2866ad90457115839e03183653961fa7e1d",
      "old_mode": 33188,
      "old_path": "src/libANGLE/Surface_unittest.cpp",
      "new_id": "602ecb249b248e91cadcd1a0a2afc879eec3efe7",
      "new_mode": 33188,
      "new_path": "src/libANGLE/Surface_unittest.cpp"
    },
    {
      "type": "modify",
      "old_id": "ccf6193b8d10903dda2deddeb05ec7356badd3ca",
      "old_mode": 33188,
      "old_path": "src/libANGLE/Texture.cpp",
      "new_id": "934108d7646a66acae3230b8caa58f4137a0550f",
      "new_mode": 33188,
      "new_path": "src/libANGLE/Texture.cpp"
    },
    {
      "type": "modify",
      "old_id": "b7445014c9a8cb27337488c313f5944af2d93cac",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/SurfaceImpl.cpp",
      "new_id": "de2e0e199a09a94d448350c489df808872e7b44e",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/SurfaceImpl.cpp"
    },
    {
      "type": "modify",
      "old_id": "b628178135d89d1850745dae6530bb60a31e5392",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/SurfaceImpl.h",
      "new_id": "7f94d5ed91e5289e71ef8d9f6053892a38bc03f1",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/SurfaceImpl.h"
    },
    {
      "type": "modify",
      "old_id": "1cc035b4bc53348abf9be5bf73fedb81ebabe4ec",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/d3d/SurfaceD3D.cpp",
      "new_id": "8dcc225c10e4c6437a276bd7f03a2efa62835831",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/d3d/SurfaceD3D.cpp"
    },
    {
      "type": "modify",
      "old_id": "b7afea3433f3b40178eae64f9ec4de0f02fc9fa3",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/d3d/SurfaceD3D.h",
      "new_id": "62d1224075ae694dc8aacde5862c5ccd21b736f1",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/d3d/SurfaceD3D.h"
    },
    {
      "type": "modify",
      "old_id": "942c77eecac85d9219d3dd4b373840edfa5bc688",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/d3d/TextureD3D.cpp",
      "new_id": "98cf8da8bf561cb48d1f7b9eeaefe2ed46662ed3",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/d3d/TextureD3D.cpp"
    },
    {
      "type": "modify",
      "old_id": "4071c0440032eed646c9573f523c93cc4223435e",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/gl/cgl/IOSurfaceSurfaceCGL.cpp",
      "new_id": "b9033e881fce278db46eb513fabf5facbc247ddc",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/gl/cgl/IOSurfaceSurfaceCGL.cpp"
    },
    {
      "type": "modify",
      "old_id": "62c3196cfa29bbfae230b6b9c9678966731cde06",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/gl/cgl/IOSurfaceSurfaceCGL.h",
      "new_id": "c387d5458af4833e0d2c99601c72eaaa6b2e53be",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/gl/cgl/IOSurfaceSurfaceCGL.h"
    },
    {
      "type": "modify",
      "old_id": "ee1cd91e9959399f5d7d97bfd4d4d3990756771a",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/gl/cgl/PbufferSurfaceCGL.cpp",
      "new_id": "c7e45b7ce0936e2af69eead299049845a1094ba1",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/gl/cgl/PbufferSurfaceCGL.cpp"
    },
    {
      "type": "modify",
      "old_id": "936fd52898200f55844f57060c5c6c423165610f",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/gl/cgl/PbufferSurfaceCGL.h",
      "new_id": "08f512cb9da18201493c6e3c9576e6cbb0d41e9e",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/gl/cgl/PbufferSurfaceCGL.h"
    },
    {
      "type": "modify",
      "old_id": "a63f38adbb44d91dcd8d9db6c33e283d78f3f03f",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.h",
      "new_id": "477b780b53cb82fbe9f4145ab608bcc031abe59d",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.h"
    },
    {
      "type": "modify",
      "old_id": "c95214600e8e21c3d6a6db6423e6ad502f9396f4",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.mm",
      "new_id": "8bdb13b83b3ba7d7deaf3a3c0b0a1a08b3783855",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.mm"
    },
    {
      "type": "modify",
      "old_id": "1032cc7e6e82aad1a71db3e1fc708a25efcead14",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/gl/egl/DisplayEGL.cpp",
      "new_id": "38846fd9541cebfc166203542da85581dea54d02",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/gl/egl/DisplayEGL.cpp"
    },
    {
      "type": "modify",
      "old_id": "dc8fe0df1d5cb968516f1bfdad5bda0edbbae401",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/gl/egl/SurfaceEGL.cpp",
      "new_id": "9d61275a5c50474328084e222e83166d0ac469d8",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/gl/egl/SurfaceEGL.cpp"
    },
    {
      "type": "modify",
      "old_id": "35678a34da920b5fe61f603b3db9e28474f47aa9",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/gl/egl/SurfaceEGL.h",
      "new_id": "1b9eee791a7a08f4cc562ae9b9589a815939a4d5",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/gl/egl/SurfaceEGL.h"
    },
    {
      "type": "modify",
      "old_id": "010248b90cd4234bfb9343e5b16703eaa6a11bd6",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/gl/glx/PbufferSurfaceGLX.cpp",
      "new_id": "939e2fc55b4205bd5f8b0ebb4faf1667e7e8208e",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/gl/glx/PbufferSurfaceGLX.cpp"
    },
    {
      "type": "modify",
      "old_id": "1875ad86345a60fbe4652b05e2d6fe51bba7c6f7",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/gl/glx/PbufferSurfaceGLX.h",
      "new_id": "35a2ae4c51ec3986e8885a48b4f1d579eb723bec",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/gl/glx/PbufferSurfaceGLX.h"
    },
    {
      "type": "modify",
      "old_id": "2fa4057755a7708ded245eef47e18218fc33b406",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/gl/glx/PixmapSurfaceGLX.cpp",
      "new_id": "8c9369a906febfa8013662eae81da467bbe64457",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/gl/glx/PixmapSurfaceGLX.cpp"
    },
    {
      "type": "modify",
      "old_id": "d2b1b98b335334088ddc30c2913f045783cf986a",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/gl/glx/PixmapSurfaceGLX.h",
      "new_id": "18d7a0a9b1037b53ed9cd4c52cdf0a0af077cc6c",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/gl/glx/PixmapSurfaceGLX.h"
    },
    {
      "type": "modify",
      "old_id": "feaca0bdd07b2e34f79b7ffea6f7623e1abdca97",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/gl/glx/WindowSurfaceGLX.cpp",
      "new_id": "7fc5387de2046b69c6e98c70d695c0ca13189efe",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/gl/glx/WindowSurfaceGLX.cpp"
    },
    {
      "type": "modify",
      "old_id": "4bdb113e328fd7326505a82048c0696649ce2692",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/gl/glx/WindowSurfaceGLX.h",
      "new_id": "47cfe874937333dd26be861565c0eeef4e0147b0",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/gl/glx/WindowSurfaceGLX.h"
    },
    {
      "type": "modify",
      "old_id": "dd48208a19d5bd394987bc62f5aeb4a95e02f4c8",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/gl/wgl/D3DTextureSurfaceWGL.cpp",
      "new_id": "851a45359cc678297694213bb1c6e665b98f9d0b",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/gl/wgl/D3DTextureSurfaceWGL.cpp"
    },
    {
      "type": "modify",
      "old_id": "33cc2808a650095da6fb236cd38b4284ad6a05f3",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/gl/wgl/D3DTextureSurfaceWGL.h",
      "new_id": "118082217a0dc11af58e275ca74b87d3cf4f27cd",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/gl/wgl/D3DTextureSurfaceWGL.h"
    },
    {
      "type": "modify",
      "old_id": "6e05ce6af67f25a6ad3c4be6a75731b040156544",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/gl/wgl/DXGISwapChainWindowSurfaceWGL.cpp",
      "new_id": "4e4df1a0b0a1a0ef801018f47f3b35a327065fa3",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/gl/wgl/DXGISwapChainWindowSurfaceWGL.cpp"
    },
    {
      "type": "modify",
      "old_id": "381c2ca1c6dac235a9732e695862eb18d0029d39",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/gl/wgl/DXGISwapChainWindowSurfaceWGL.h",
      "new_id": "7684fedfdad17456b88995f2cb918f23c0886f8c",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/gl/wgl/DXGISwapChainWindowSurfaceWGL.h"
    },
    {
      "type": "modify",
      "old_id": "2f1ad3e1d64aad87686e83998e646efafde94b96",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/gl/wgl/PbufferSurfaceWGL.cpp",
      "new_id": "67449f8a65670ecaf74b92c905e414b053901cbf",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/gl/wgl/PbufferSurfaceWGL.cpp"
    },
    {
      "type": "modify",
      "old_id": "1861736662fe3a6917923d79ee39d5dea48a4cb7",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/gl/wgl/PbufferSurfaceWGL.h",
      "new_id": "314d92daec4eda36a9618415239f521aa322e8dd",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/gl/wgl/PbufferSurfaceWGL.h"
    },
    {
      "type": "modify",
      "old_id": "227e94725c1e031e9e58fd9e9ff0708bf99efe4b",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/gl/wgl/WindowSurfaceWGL.cpp",
      "new_id": "c1d1b3bf4d8a9258201186fe6368a21a2f3aa572",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/gl/wgl/WindowSurfaceWGL.cpp"
    },
    {
      "type": "modify",
      "old_id": "3e4f83b24d31431dd9617cd60673d7b64151cb22",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/gl/wgl/WindowSurfaceWGL.h",
      "new_id": "5a81305f6c5bdcb6da496804481b5ff60f6c2f31",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/gl/wgl/WindowSurfaceWGL.h"
    },
    {
      "type": "modify",
      "old_id": "444fa8a6dfdf25c6d3c3029c97a7a03a387eff91",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/metal/SurfaceMtl.h",
      "new_id": "004de337a617d892fda57924883ac9a034ca45ea",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/metal/SurfaceMtl.h"
    },
    {
      "type": "modify",
      "old_id": "04bff707a1088897091e646c0c885f892548e639",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/metal/SurfaceMtl.mm",
      "new_id": "e57fb5018b02aede76376ae68f119fe777d5d2c8",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/metal/SurfaceMtl.mm"
    },
    {
      "type": "modify",
      "old_id": "ea3560c62be7504d5d503bda4c5e89a2c2322f92",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/null/SurfaceNULL.cpp",
      "new_id": "f6bc6e4d6ce1b29f514b668e38309b7ecac6417e",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/null/SurfaceNULL.cpp"
    },
    {
      "type": "modify",
      "old_id": "eb1d3ca34e318cf2d8e0076c935526a38841efd3",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/null/SurfaceNULL.h",
      "new_id": "6773e1878d2c9ff40d16f2e166598e4cb81739d0",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/null/SurfaceNULL.h"
    },
    {
      "type": "modify",
      "old_id": "2848bc0484e8941d8caac281c8bc019febe9d124",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/vulkan/SurfaceVk.cpp",
      "new_id": "ae1e2f56cc4914740b602e9fdc915c48fd12f462",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/vulkan/SurfaceVk.cpp"
    },
    {
      "type": "modify",
      "old_id": "93d000f170059bf3edfd29a81a1a27a8536759ba",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/vulkan/SurfaceVk.h",
      "new_id": "644aba3a9a119053f0ff60e9c729e334448420ea",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/vulkan/SurfaceVk.h"
    },
    {
      "type": "modify",
      "old_id": "da02287ba8c075dbbdb3229748d885b17d6c53cb",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/wgpu/SurfaceWgpu.cpp",
      "new_id": "a6591aa4c8660d508b2b5f3ba9eb6f3e2ed27212",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/wgpu/SurfaceWgpu.cpp"
    },
    {
      "type": "modify",
      "old_id": "de2b086d1f05982b0c79014ecdede47760bc7ff3",
      "old_mode": 33188,
      "old_path": "src/libANGLE/renderer/wgpu/SurfaceWgpu.h",
      "new_id": "8da4ca2026be1285e9c23733ae23b6cc520b15db",
      "new_mode": 33188,
      "new_path": "src/libANGLE/renderer/wgpu/SurfaceWgpu.h"
    }
  ]
}