As an ANGLE Sheriff. Your job is to:
If you're not an ANGLE team member, you can contact us on the public ANGLE project Google group.
Note: It‘s highly recommend that all wranglers install the Chromium Flake Linker extension for inspecting bot builds. It’ll save you a lot of time.
Your first job is to keep the ANGLE Try Waterfall healthy. Some failures are expected on this waterfall. Developers might be testing expectedly buggy code. But persistent flakiness and failures should be reported and reverted.
When encoutering an unexpected failure in your CLs please file an ANGLE bug and cc the current ANGLE wrangler. If the failure is unrelated to ANGLE file a Chromium bug and mark the bug as
Hotlist-PixelWrangler. Refer to build.chromium.org to find the current ANGLE wrangler and GPU Pixel Wrangler.
NOTE: When all builds seem to be purple or otherwise broken:
This could be a major infrastructure outage. File a high-priority bug using g.co/bugatrooper.
ANGLE bugs sometimes make it past the commit queue testing and into the master branch. This can be because of flaky tests or because the failures are specific to system configurations for which we lack full pre-commit testing support.
The Chromium GPU FYI Waterfall waterfall includes a number of these one-off specialized configurations. Monitor this console for persistent breakage that could be related to ANGLE. Also follow the
Internals>GPU>ANGLE component on the Chromium issue tracker to be alerted to reports of breakage on the GPU.FYI waterfall. Googlers can use sheriff-o-matic to monitor the health of the GPU.FYI waterfall.
Note that the GPU Pixel Wrangler is responsible for the Chromium bugs. Please file issues with the tag
Hotlist-PixelWrangler for bugs that aren't caused by ANGLE regressions.
IMPORTANT: Info to include in bug reports:
parent_got_angle_revisionin both builds.
https://chromium.googlesource.com/angle/angle.git/+log/<last passing revision>..<first failing revision>
The ANGLE auto-roller automatically updates Chrome with the latest ANGLE changes.
We also use additional auto-rollers to roll third party libraries into ANGLE once per day:
Please ensure these rollers are also healthy and unblocked. You can trigger manual rolls using the dashboards to land high-priority changes.
NOTE: When Vulkan-Headers roll is broken:
The Vulkan-Tools, Vulkan-Loader, and Vulkan-ValidationLayers repos all depend on the Vulkan-Headers repo. When Vulkan-Headers updates, all of those repos have a roll process managed by LunarG to update them for the new Vulkan-Headers. This usually takes 2-3 business days after the Vulkan-Headers update. If Vulkan-Headers roll fails, pause the roller with a note that it should be re-enabled when the dependent repos have been updated for the latest Vulkan-Headers changes. This will require a manual roll if the two repos have to be rolled in unison. To perform a manual roll, create a CL that updates the DEPS file with the new SHA1 value from the desired checkout of each dependent repo. Once the manual roll lands, re-enable the auto-rollers for the relevant repos.
See more detailed instructions on by following this link.
Most important task here is to keep healthy the 2 SwANGLE bots on ANGLE CQ, linux-swangle-try-tot-angle-x64 and win-swangle-try-tot-angle-x86. As well as the 2 SwANGLE bots used for ANGLE rolls on Chromium CQ, linux-swangle-try-x64 and win-swangle-try-x86.
Same instructions as for Task 1 apply here. Some failures on these bots may be due to SwiftShader changes, however. The possible ways to handle these failures are:
Any large regressions should be triaged with a new ANGLE bug linked to any suspected CLs that may have caused performance to regress. If it's a known/expected regression, the bug can be closed as such. The tests are very flaky right now, so a WontFix resolution is often appropriate.