libbrillo: migrate usage of deprecated base::Value methods
base::ListValue::DeepCopy() and base::DictionaryValue::DeepCopy() have
been deprecated and will eventually be removed from libchrome. This CL
migrates the usage of these deprecated methods in the libbrillo code to
the equivalent base::ListValue::CreateDeepCopy() and
base::DictionaryValue::CreateDeepCopy().
BUG=chromium:689697
TEST=Run unit tests.
Change-Id: If8fa22c5830ffbd885d66bf63e7afaf662fd1ec3
Reviewed-on: https://chromium-review.googlesource.com/438798
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
diff --git a/brillo/value_conversion.cc b/brillo/value_conversion.cc
index aa5135b..9f8eab1 100644
--- a/brillo/value_conversion.cc
+++ b/brillo/value_conversion.cc
@@ -24,7 +24,7 @@
const base::ListValue* list = nullptr;
if (!in_value.GetAsList(&list))
return false;
- out_value->reset(list->DeepCopy());
+ *out_value = list->CreateDeepCopy();
return true;
}
@@ -33,7 +33,7 @@
const base::DictionaryValue* dict = nullptr;
if (!in_value.GetAsDictionary(&dict))
return false;
- out_value->reset(dict->DeepCopy());
+ *out_value = dict->CreateDeepCopy();
return true;
}
