commit 95954faecf0d6476634de64baed7082622ec0627
author Ryo Hashimoto <hashimoto@google.com> Fri Jul 17 11:40:59 2020
committer Commit Bot <commit-bot@chromium.org> Tue Jul 28 16:33:03 2020
tree 7b18296ce979e3569aec788cdf8b094369ef523e
parent 7bdd7e99b6f24d01e8fd08a588333bfbcd3d62c2

Explicitly export symbols

BUG=chromium:1108297
TEST=build

Cq-Depend: chromium:2303160
Change-Id: I7ca22bcca72a23346387a2c517a4a3aacc275cfc
Reviewed-on: https://chromium-review.googlesource.com/c/aosp/platform/external/libchrome/+/2303419
Tested-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>

BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn
index d862945..f3c21d4 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -57,6 +57,22 @@
   ]
 }
 
+config("base_export_config") {
+  defines = [ "COMPONENT_BUILD", "BASE_IMPLEMENTATION" ]
+}
+
+config("crypto_export_config") {
+  defines = [ "COMPONENT_BUILD", "CRYPTO_IMPLEMENTATION" ]
+}
+
+config("dbus_export_config") {
+  defines = [ "COMPONENT_BUILD", "DBUS_IMPLEMENTATION" ]
+}
+
+config("policy_export_config") {
+  defines = [ "COMPONENT_BUILD", "POLICY_COMPONENT_IMPLEMENTATION" ]
+}
+
 libbase_sublibs = [
   {
     name = "base-core"
@@ -70,7 +86,7 @@
       "glib-2.0",
       "libevent",
     ]
-    configs = [ ":base_core_config" ]
+    configs = [ ":base_core_config", ":base_export_config" ]
     sources = [
       "base/allocator/allocator_extension.cc",
       "base/at_exit.cc",
@@ -336,6 +352,7 @@
     output_name = name + "-${libbase_ver}"
     deps = [ ":base-core" ]
     libs = [ "dl" ]
+    configs = [ ":base_export_config" ]
     sources = [
       "base/allocator/allocator_shim.cc",
       "base/allocator/allocator_shim_default_dispatch_to_glibc.cc",
@@ -350,6 +367,7 @@
     output_name = name + "-${libbase_ver}"
     deps = [ ":base-core" ]
     libs = [ "re2" ]
+    configs = [ ":policy_export_config" ]
     sources = [
       "components/policy/core/common/json_schema_constants.cc",
       "components/policy/core/common/policy_load_status.cc",
@@ -387,10 +405,12 @@
         ":base-core",
         ":base-dl",
       ]
+      libs = [ "dl" ]
       pkg_deps = [
         "nss",
         "openssl",
       ]
+      configs = [ ":crypto_export_config" ]
       sources = [
         "crypto/hmac.cc",
         "crypto/hmac_nss.cc",
@@ -431,6 +451,7 @@
       } else {
         pkg_deps += [ "protobuf-lite" ]
       }
+      configs = [ ":dbus_export_config" ]
       sources = [
         "dbus/bus.cc",
         "dbus/dbus_statistics.cc",
@@ -473,6 +494,7 @@
       name = "base-timers"
       output_name = name + "-${libbase_ver}"
       deps = [ ":base-core" ]
+      configs = [ "//common-mk:visibility_default" ]
       sources = [ "components/timers/alarm_timer_chromeos.cc" ]
     },
 
@@ -515,7 +537,6 @@
     }
     configs += [
       ":libchrome_config",
-      "//common-mk:visibility_default",
     ]
     if (buildtype == "static_library") {
       configs -= [ "//common-mk:use_thin_archive" ]