shill: Cleanup metrics logic tracking online state
1. was_online_ is meant to leave notes for future invocations
of NotifyDefaultServiceChanged, and meant to be used along with
last_default_technology_. Change it to was_last_online to make the
connection more obvious.
2. "Ignore changes that are not online/offline transitions" is
hard to read. This should be "only consider transitions b/w
online and offline". Make that snippet more readable.
TEST=shill unit-tests pass
Signed-off-by: Kirtika Ruchandani <firstname.lastname@example.org>
Commit-Ready: Kirtika Ruchandani <email@example.com>
Tested-by: Kirtika Ruchandani <firstname.lastname@example.org>
Reviewed-by: Luigi Semenzato <email@example.com>
2 files changed