shill: construct ICMP echo reply callback in place

This CL removes the member variable |echo_reply_callback_| of
IcmpSession as it's only used once when creating the input handler for
echo reply and thus can be constructed in place.

BUG=None
TEST=Run unit tests.

Change-Id: If9bbf531dec7334cfa2841e24c878e3b3a16d0c6
Reviewed-on: https://chromium-review.googlesource.com/441305
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
2 files changed
tree: 00e4a022328a2d179ca5056663e72e4f8f3202c9
  1. .gitignore
  2. Android.mk
  3. HACKING
  4. MODULE_LICENSE_APACHE2
  5. NETLINK_MESSAGES.txt
  6. NOTICE
  7. OWNERS
  8. PRESUBMIT.cfg
  9. TESTING
  10. accessor_interface.h
  11. active_link_monitor.cc
  12. active_link_monitor.h
  13. active_link_monitor_unittest.cc
  14. adaptor_interfaces.h
  15. adaptor_stub.cc
  16. adaptor_stub.h
  17. async_connection.cc
  18. async_connection.h
  19. async_connection_unittest.cc
  20. bin/
  21. binder/
  22. callbacks.h
  23. cellular/
  24. certificate_file.cc
  25. certificate_file.h
  26. certificate_file_unittest.cc
  27. connection.cc
  28. connection.h
  29. connection_diagnostics.cc
  30. connection_diagnostics.h
  31. connection_diagnostics_unittest.cc
  32. connection_health_checker.cc
  33. connection_health_checker.h
  34. connection_health_checker_unittest.cc
  35. connection_info.cc
  36. connection_info.h
  37. connection_info_reader.cc
  38. connection_info_reader.h
  39. connection_info_reader_unittest.cc
  40. connection_info_unittest.cc
  41. connection_tester.cc
  42. connection_tester.h
  43. connection_tester_unittest.cc
  44. connection_unittest.cc
  45. connectivity_trial.cc
  46. connectivity_trial.h
  47. connectivity_trial_unittest.cc
  48. control_interface.h
  49. crypto_des_cbc.cc
  50. crypto_des_cbc.h
  51. crypto_des_cbc_unittest.cc
  52. crypto_interface.h
  53. crypto_provider.cc
  54. crypto_provider.h
  55. crypto_provider_unittest.cc
  56. crypto_rot47.cc
  57. crypto_rot47.h
  58. crypto_rot47_unittest.cc
  59. crypto_util_proxy.cc
  60. crypto_util_proxy.h
  61. crypto_util_proxy_unittest.cc
  62. daemon_task.cc
  63. daemon_task.h
  64. daemon_task_unittest.cc
  65. dbus/
  66. dbus_bindings/
  67. dbus_properties_proxy_interface.h
  68. default_profile.cc
  69. default_profile.h
  70. default_profile_unittest.cc
  71. device.cc
  72. device.h
  73. device_claimer.cc
  74. device_claimer.h
  75. device_claimer_unittest.cc
  76. device_info.cc
  77. device_info.h
  78. device_info_unittest.cc
  79. device_stub.h
  80. device_unittest.cc
  81. dhcp/
  82. dns_client.cc
  83. dns_client.h
  84. dns_client_factory.cc
  85. dns_client_factory.h
  86. dns_client_unittest.cc
  87. dns_server_proxy.cc
  88. dns_server_proxy.h
  89. dns_server_proxy_factory.cc
  90. dns_server_proxy_factory.h
  91. dns_server_tester.cc
  92. dns_server_tester.h
  93. dns_server_tester_unittest.cc
  94. doc/
  95. eap_credentials.cc
  96. eap_credentials.h
  97. eap_credentials_unittest.cc
  98. eap_listener.cc
  99. eap_listener.h
  100. eap_listener_unittest.cc
  101. eap_protocol.h
  102. ephemeral_profile.cc
  103. ephemeral_profile.h
  104. error.cc
  105. error.h
  106. error_unittest.cc
  107. ethernet/
  108. event_dispatcher.cc
  109. event_dispatcher.h
  110. external_task.cc
  111. external_task.h
  112. external_task_unittest.cc
  113. fake_store.cc
  114. fake_store.h
  115. file_io.cc
  116. file_io.h
  117. file_reader.cc
  118. file_reader.h
  119. file_reader_unittest.cc
  120. firewall_proxy_interface.h
  121. geolocation_info.cc
  122. geolocation_info.h
  123. hook_table.cc
  124. hook_table.h
  125. hook_table_unittest.cc
  126. http_request.cc
  127. http_request.h
  128. http_request_unittest.cc
  129. http_url.cc
  130. http_url.h
  131. http_url_unittest.cc
  132. icmp.cc
  133. icmp.h
  134. icmp_session.cc
  135. icmp_session.h
  136. icmp_session_factory.cc
  137. icmp_session_factory.h
  138. icmp_session_unittest.cc
  139. icmp_unittest.cc
  140. init/
  141. ip_address_store.cc
  142. ip_address_store.h
  143. ip_address_store_unittest.cc
  144. ipconfig.cc
  145. ipconfig.h
  146. ipconfig_adaptor_stub.cc
  147. ipconfig_adaptor_stub.h
  148. ipconfig_unittest.cc
  149. json_store.cc
  150. json_store.h
  151. json_store_unittest.cc
  152. key_file_store.cc
  153. key_file_store.h
  154. key_file_store_unittest.cc
  155. key_value_store.cc
  156. key_value_store.h
  157. key_value_store_unittest.cc
  158. libshill-client-test.pc.in
  159. libshill-client.pc.in
  160. link_monitor.cc
  161. link_monitor.h
  162. link_monitor_unittest.cc
  163. logging.cc
  164. logging.h
  165. manager.cc
  166. manager.h
  167. manager_unittest.cc
  168. metrics.cc
  169. metrics.h
  170. metrics_unittest.cc
  171. mobile_operator_db/
  172. mock_active_link_monitor.cc
  173. mock_active_link_monitor.h
  174. mock_adaptors.cc
  175. mock_adaptors.h
  176. mock_ares.cc
  177. mock_ares.h
  178. mock_async_connection.cc
  179. mock_async_connection.h
  180. mock_certificate_file.cc
  181. mock_certificate_file.h
  182. mock_connection.cc
  183. mock_connection.h
  184. mock_connection_health_checker.cc
  185. mock_connection_health_checker.h
  186. mock_connection_info_reader.cc
  187. mock_connection_info_reader.h
  188. mock_connectivity_trial.cc
  189. mock_connectivity_trial.h
  190. mock_control.cc
  191. mock_control.h
  192. mock_crypto_util_proxy.cc
  193. mock_crypto_util_proxy.h
  194. mock_dbus_manager.cc
  195. mock_dbus_manager.h
  196. mock_dbus_properties_proxy.cc
  197. mock_dbus_properties_proxy.h
  198. mock_device.cc
  199. mock_device.h
  200. mock_device_claimer.cc
  201. mock_device_claimer.h
  202. mock_device_info.cc
  203. mock_device_info.h
  204. mock_dns_client.cc
  205. mock_dns_client.h
  206. mock_dns_client_factory.cc
  207. mock_dns_client_factory.h
  208. mock_dns_server_proxy.cc
  209. mock_dns_server_proxy.h
  210. mock_dns_server_proxy_factory.cc
  211. mock_dns_server_proxy_factory.h
  212. mock_dns_server_tester.cc
  213. mock_dns_server_tester.h
  214. mock_eap_credentials.cc
  215. mock_eap_credentials.h
  216. mock_eap_listener.cc
  217. mock_eap_listener.h
  218. mock_event_dispatcher.cc
  219. mock_event_dispatcher.h
  220. mock_external_task.cc
  221. mock_external_task.h
  222. mock_file_io.h
  223. mock_firewall_proxy.h
  224. mock_http_request.cc
  225. mock_http_request.h
  226. mock_icmp.cc
  227. mock_icmp.h
  228. mock_icmp_session.cc
  229. mock_icmp_session.h
  230. mock_icmp_session_factory.cc
  231. mock_icmp_session_factory.h
  232. mock_ip_address_store.cc
  233. mock_ip_address_store.h
  234. mock_ipconfig.cc
  235. mock_ipconfig.h
  236. mock_link_monitor.cc
  237. mock_link_monitor.h
  238. mock_log.cc
  239. mock_log.h
  240. mock_log_unittest.cc
  241. mock_manager.cc
  242. mock_manager.h
  243. mock_metrics.cc
  244. mock_metrics.h
  245. mock_passive_link_monitor.cc
  246. mock_passive_link_monitor.h
  247. mock_pending_activation_store.cc
  248. mock_pending_activation_store.h
  249. mock_portal_detector.cc
  250. mock_portal_detector.h
  251. mock_power_manager.cc
  252. mock_power_manager.h
  253. mock_power_manager_proxy.cc
  254. mock_power_manager_proxy.h
  255. mock_ppp_device.cc
  256. mock_ppp_device.h
  257. mock_ppp_device_factory.cc
  258. mock_ppp_device_factory.h
  259. mock_process_manager.cc
  260. mock_process_manager.h
  261. mock_profile.cc
  262. mock_profile.h
  263. mock_property_store.cc
  264. mock_property_store.h
  265. mock_resolver.cc
  266. mock_resolver.h
  267. mock_routing_table.cc
  268. mock_routing_table.h
  269. mock_service.cc
  270. mock_service.h
  271. mock_socket_info_reader.cc
  272. mock_socket_info_reader.h
  273. mock_store.cc
  274. mock_store.h
  275. mock_throttler.cc
  276. mock_throttler.h
  277. mock_traffic_monitor.cc
  278. mock_traffic_monitor.h
  279. mock_virtual_device.cc
  280. mock_virtual_device.h
  281. net/
  282. nice_mock_control.cc
  283. nice_mock_control.h
  284. passive_link_monitor.cc
  285. passive_link_monitor.h
  286. passive_link_monitor_unittest.cc
  287. pending_activation_store.cc
  288. pending_activation_store.h
  289. pending_activation_store_unittest.cc
  290. portal_detector.cc
  291. portal_detector.h
  292. portal_detector_unittest.cc
  293. power_manager.cc
  294. power_manager.h
  295. power_manager_proxy_interface.h
  296. power_manager_proxy_stub.cc
  297. power_manager_proxy_stub.h
  298. power_manager_unittest.cc
  299. ppp_daemon.cc
  300. ppp_daemon.h
  301. ppp_daemon_unittest.cc
  302. ppp_device.cc
  303. ppp_device.h
  304. ppp_device_factory.cc
  305. ppp_device_factory.h
  306. ppp_device_unittest.cc
  307. pppoe/
  308. process_manager.cc
  309. process_manager.h
  310. process_manager_unittest.cc
  311. profile.cc
  312. profile.h
  313. profile_adaptor_stub.cc
  314. profile_adaptor_stub.h
  315. profile_unittest.cc
  316. property_accessor.h
  317. property_accessor_unittest.cc
  318. property_iterator.h
  319. property_observer.h
  320. property_observer_interface.h
  321. property_observer_unittest.cc
  322. property_store.cc
  323. property_store.h
  324. property_store_unittest.cc
  325. property_store_unittest.h
  326. protobuf_lite_streams.cc
  327. protobuf_lite_streams.h
  328. provider_db_unittest.bfd
  329. provider_interface.h
  330. refptr_types.h
  331. resolver.cc
  332. resolver.h
  333. resolver_unittest.cc
  334. result_aggregator.cc
  335. result_aggregator.h
  336. result_aggregator_unittest.cc
  337. routing_table.cc
  338. routing_table.h
  339. routing_table_entry.h
  340. routing_table_unittest.cc
  341. rpc_service_watcher_interface.h
  342. rpc_task.cc
  343. rpc_task.h
  344. rpc_task_adaptor_stub.cc
  345. rpc_task_adaptor_stub.h
  346. rpc_task_unittest.cc
  347. scope_logger.cc
  348. scope_logger.h
  349. scope_logger_unittest.cc
  350. scoped_umask.cc
  351. scoped_umask.h
  352. service.cc
  353. service.h
  354. service_property_change_notifier.cc
  355. service_property_change_notifier.h
  356. service_property_change_test.cc
  357. service_property_change_test.h
  358. service_sorter.h
  359. service_under_test.cc
  360. service_under_test.h
  361. service_unittest.cc
  362. setup_wifi/
  363. shill-client.gyp
  364. shill.gyp
  365. shill.gypi
  366. shill.rc
  367. shill_ares.cc
  368. shill_ares.h
  369. shill_config.cc
  370. shill_config.h
  371. shill_daemon.cc
  372. shill_daemon.h
  373. shill_main.cc
  374. shill_test_config.cc
  375. shill_test_config.h
  376. shims/
  377. socket_info.cc
  378. socket_info.h
  379. socket_info_reader.cc
  380. socket_info_reader.h
  381. socket_info_reader_unittest.cc
  382. socket_info_unittest.cc
  383. static_ip_parameters.cc
  384. static_ip_parameters.h
  385. static_ip_parameters_unittest.cc
  386. store_factory.cc
  387. store_factory.h
  388. store_interface.h
  389. stub_storage.h
  390. supplicant/
  391. technology.cc
  392. technology.h
  393. technology_unittest.cc
  394. test-rpc-proxy/
  395. test-scripts/
  396. test_event_dispatcher.h
  397. testing.h
  398. testrunner.cc
  399. tethering.cc
  400. tethering.h
  401. third_party_vpn_adaptor_stub.cc
  402. third_party_vpn_adaptor_stub.h
  403. throttler.cc
  404. throttler.h
  405. throttler_unittest.cc
  406. traffic_monitor.cc
  407. traffic_monitor.h
  408. traffic_monitor_unittest.cc
  409. udev/
  410. upstart/
  411. virtual_device.cc
  412. virtual_device.h
  413. virtual_device_unittest.cc
  414. vpn/
  415. wifi/
  416. wimax/