)]}' { "commit": "0820a9e45f6c8b808c554b85ef1aae7c3a60787a", "tree": "489516ea76c89d25889139bf3aa1888fa40e4989", "parents": [ "c46c23e0af48c011c6e3de8d349b212063bd4171" ], "author": { "name": "Eric Caruso", "email": "ejcaruso@chromium.org", "time": "Mon Nov 14 20:56:03 2016" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Wed Nov 16 15:10:50 2016" }, "message": "shill: allow users of EventDispatcher to provide location with task\n\nSince the location is provided inside EventDispatcher::PostTask and\nEventDispatcher::PostDelayedTask, we often lose information about\nwhere the task is actually coming from in minidumps and crash reports.\nIf we move the creation of the location object to the callsites of\nEventDispatcher we should be able to get better information about\nthis.\n\nBUG\u003dNone\nTEST\u003dunit tests\n\nChange-Id: I405ad5de4e71005cbaf9d6962a1d72e1d37060f7\nReviewed-on: https://chromium-review.googlesource.com/411281\nCommit-Ready: Eric Caruso \u003cejcaruso@chromium.org\u003e\nTested-by: Eric Caruso \u003cejcaruso@chromium.org\u003e\nReviewed-by: Kirtika Ruchandani \u003ckirtika@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "c8289c0df17004695cb21e35037d93b9c66123fc", "old_mode": 33188, "old_path": "HACKING", "new_id": "141644003acd2fed2d24cdc61c284e78ddc67ef3", "new_mode": 33188, "new_path": "HACKING" }, { "type": "modify", "old_id": "534f1015795f04f3c6692e463d6a5ae2de1cafac", "old_mode": 33188, "old_path": "active_link_monitor.cc", "new_id": "bda7f95fb8b3f427faa74ecc653d93d6e125675d", "new_mode": 33188, "new_path": "active_link_monitor.cc" }, { "type": "modify", "old_id": "211d948055070b3cff3648f3b85aebd602b9d5e1", "old_mode": 33188, "old_path": "active_link_monitor_unittest.cc", "new_id": "2f8faca2e2f235506fd51591b51167b734f545e4", "new_mode": 33188, "new_path": "active_link_monitor_unittest.cc" }, { "type": "modify", "old_id": "21b046a9ddcc557a761f5b1c2e90f612599cd82d", "old_mode": 33188, "old_path": "binder/binder_control.cc", "new_id": "b332eb946a67cbecf36e1243d8443d527261f201", "new_mode": 33188, "new_path": "binder/binder_control.cc" }, { "type": "modify", "old_id": "de7292d15b168bb5a2149ba812ae4424a59d5c3d", "old_mode": 33188, "old_path": "cellular/active_passive_out_of_credits_detector.cc", "new_id": "89dd0c36a237a8604c031b20c4c80f6ec4f844e4", "new_mode": 33188, "new_path": "cellular/active_passive_out_of_credits_detector.cc" }, { "type": "modify", "old_id": "90e4cacb914d379e9c24ae606414dde07bd11599", "old_mode": 33188, "old_path": "cellular/cellular.cc", "new_id": "a9a4d5741068030bbea7265b5371649c63592f94", "new_mode": 33188, "new_path": "cellular/cellular.cc" }, { "type": "modify", "old_id": "6bfed82cf3ff39ee5ed9a40f7b6c75c5addef5e4", "old_mode": 33188, "old_path": "cellular/cellular_capability_classic.cc", "new_id": "28391cf8a3c926ec6c815845ecd9ec2b7c1101ac", "new_mode": 33188, "new_path": "cellular/cellular_capability_classic.cc" }, { "type": "modify", "old_id": "6e6d0b89c7faeb4474048249a232eafb94ac2723", "old_mode": 33188, "old_path": "cellular/cellular_capability_gsm.cc", "new_id": "098636b14231f2f4514b22a756762d2fd6e92118", "new_mode": 33188, "new_path": "cellular/cellular_capability_gsm.cc" }, { "type": "modify", "old_id": "47881a38f35f2c190619112484cf534de1e05464", "old_mode": 33188, "old_path": "cellular/cellular_capability_universal.cc", "new_id": "42be146b94832ac423a2f078535d00569ff2169b", "new_mode": 33188, "new_path": "cellular/cellular_capability_universal.cc" }, { "type": "modify", "old_id": "2becef8d835cbcb39b0c85d35bb83e3ae7bec399", "old_mode": 33188, "old_path": "cellular/cellular_capability_universal_cdma.cc", "new_id": "176bcbcaabd589f4232be23ed318f0d4e66c4c21", "new_mode": 33188, "new_path": "cellular/cellular_capability_universal_cdma.cc" }, { "type": "modify", "old_id": "c2cb98489380d1fe3a9f261c756fbe1138987192", "old_mode": 33188, "old_path": "cellular/cellular_capability_universal_cdma_unittest.cc", "new_id": "7aa5107447ca4e178970f8de06182d828ca90c8d", "new_mode": 33188, "new_path": "cellular/cellular_capability_universal_cdma_unittest.cc" }, { "type": "modify", "old_id": "5d8b1a973ce5c6253fc97f7f75feeac99886e17f", "old_mode": 33188, "old_path": "cellular/mobile_operator_info_impl.cc", "new_id": "6468131375a3e63c082ab7f36fa94dcda946f1ce", "new_mode": 33188, "new_path": "cellular/mobile_operator_info_impl.cc" }, { "type": "modify", "old_id": "a9d12c132e020e0ab348469cafde8b8a9b1f22b8", "old_mode": 33188, "old_path": "connection_diagnostics.cc", "new_id": "4c7c0cdbfb89515aa7e4bb49ddf1c9de87526cc9", "new_mode": 33188, "new_path": "connection_diagnostics.cc" }, { "type": "modify", "old_id": "b22809441ee4fa2e4a6aed943525a1566771687c", "old_mode": 33188, "old_path": "connection_diagnostics_unittest.cc", "new_id": "7236b19db050b6909ce8be74fb9aba51f1b67fe2", "new_mode": 33188, "new_path": "connection_diagnostics_unittest.cc" }, { "type": "modify", "old_id": "bc7b5c5fdee24897aea9867bd975bcd3a6d7e934", "old_mode": 33188, "old_path": "connection_health_checker.cc", "new_id": "2e4cb1299c9788e6eef4d1aaf1785c1f92f9d606", "new_mode": 33188, "new_path": "connection_health_checker.cc" }, { "type": "modify", "old_id": "fc58d287baca4402d03b68fe182785d9c7e2931c", "old_mode": 33188, "old_path": "connectivity_trial.cc", "new_id": "d68daec57e44439bf2261ddab63afce327750245", "new_mode": 33188, "new_path": "connectivity_trial.cc" }, { "type": "modify", "old_id": "cf2e70ffd12e53a135ae30c3286e4e7c800f6c58", "old_mode": 33188, "old_path": "connectivity_trial_unittest.cc", "new_id": "e970bbcc89a1deffe5ce2963e68542691f411590", "new_mode": 33188, "new_path": "connectivity_trial_unittest.cc" }, { "type": "modify", "old_id": "e8aeeac8c53594fb4f32d2d546d7a613a0c53b8d", "old_mode": 33188, "old_path": "crypto_util_proxy.cc", "new_id": "26f64bdc321939bbbc8f4f6a2ef2a8a804090156", "new_mode": 33188, "new_path": "crypto_util_proxy.cc" }, { "type": "modify", "old_id": "d942f98fea8ce99c9fdc5c4ed2e29addc5e8b9b6", "old_mode": 33188, "old_path": "crypto_util_proxy_unittest.cc", "new_id": "953b2dda644fe2524ce602c28f223c93f616c3e2", "new_mode": 33188, "new_path": "crypto_util_proxy_unittest.cc" }, { "type": "modify", "old_id": "12f9dfc12330a8eaddaf0d10db2a588683f44351", "old_mode": 33188, "old_path": "daemon_task.cc", "new_id": "2b4718cd60b646eec80ec5de65c949d2b08689cf", "new_mode": 33188, "new_path": "daemon_task.cc" }, { "type": "modify", "old_id": "d7fe41c8c91e8f7ad8b3b426ce0c0766c5104d15", "old_mode": 33188, "old_path": "daemon_task_unittest.cc", "new_id": "1bc9e7a984e791a0938f8c595ec8d9a54ea407dc", "new_mode": 33188, "new_path": "daemon_task_unittest.cc" }, { "type": "modify", "old_id": "b233a541530826baa162abbf592a858acf338db9", "old_mode": 33188, "old_path": "dbus/chromeos_dbus_objectmanager_proxy.cc", "new_id": "d42081ee070538aa3299a9bdac3c8c00b6f21980", "new_mode": 33188, "new_path": "dbus/chromeos_dbus_objectmanager_proxy.cc" }, { "type": "modify", "old_id": "b101a4d17e1e74f216ff90fed5bc8ec2fd90a0c3", "old_mode": 33188, "old_path": "dbus/chromeos_dhcpcd_listener.cc", "new_id": "a3494e1b324dfbf43a83724d485bb72dac6ba3e1", "new_mode": 33188, "new_path": "dbus/chromeos_dhcpcd_listener.cc" }, { "type": "modify", "old_id": "6b08d5898f443b2b020124bbeaaa1ea7590a6caf", "old_mode": 33188, "old_path": "dbus/chromeos_modem_manager_proxy.cc", "new_id": "245ae8de9bc78ef51d40229d5b87b6138c470396", "new_mode": 33188, "new_path": "dbus/chromeos_modem_manager_proxy.cc" }, { "type": "modify", "old_id": "27922785185740357d8d49c519d2923072052035", "old_mode": 33188, "old_path": "dbus/chromeos_power_manager_proxy.cc", "new_id": "3c67eafacf93b2a7667db7338a40b3e77c36ca1e", "new_mode": 33188, "new_path": "dbus/chromeos_power_manager_proxy.cc" }, { "type": "modify", "old_id": "34fd819340e3eab38d6b0d4e6726e63df87ddf0f", "old_mode": 33188, "old_path": "dbus/chromeos_supplicant_process_proxy.cc", "new_id": "2c5325c4ce308113e74a32a18fde3aee9c6961c7", "new_mode": 33188, "new_path": "dbus/chromeos_supplicant_process_proxy.cc" }, { "type": "modify", "old_id": "430887b847998e565028ec1a74ecd225b6978686", "old_mode": 33188, "old_path": "dbus/chromeos_wimax_manager_proxy.cc", "new_id": "3a134b950a15c1e593e5ede60d951a05d50339aa", "new_mode": 33188, "new_path": "dbus/chromeos_wimax_manager_proxy.cc" }, { "type": "modify", "old_id": "4641dad215e3acfa318f9a277ecf35c195ed86c7", "old_mode": 33188, "old_path": "device.cc", "new_id": "cd90dc86c31945afbac1c6ad174ac5114c343457", "new_mode": 33188, "new_path": "device.cc" }, { "type": "modify", "old_id": "7a2f13f37b3099b9d6a232c6d2c493e91cb8f9c1", "old_mode": 33188, "old_path": "device_info.cc", "new_id": "cfa7bd6a637e2e8c2136558cad155f26be4b7580", "new_mode": 33188, "new_path": "device_info.cc" }, { "type": "modify", "old_id": "9d731fca9c4c382b519577871dc2320737efd935", "old_mode": 33188, "old_path": "device_info_unittest.cc", "new_id": "3548c1ee6cdc264f753ba58dcc6565c15e6890c7", "new_mode": 33188, "new_path": "device_info_unittest.cc" }, { "type": "modify", "old_id": "85637cb4e7c013932266f2b818cb6efa0516cd9d", "old_mode": 33188, "old_path": "dhcp/dhcp_config.cc", "new_id": "9aa406a5ad700bee26fde012ad9a5c027ca74ef6", "new_mode": 33188, "new_path": "dhcp/dhcp_config.cc" }, { "type": "modify", "old_id": "97098b3dbf160f4b6ddab1bfa31f90d410189422", "old_mode": 33188, "old_path": "dhcp/dhcp_provider.cc", "new_id": "758afacfcf9c09f13b1c57b0902adce609b18af8", "new_mode": 33188, "new_path": "dhcp/dhcp_provider.cc" }, { "type": "modify", "old_id": "b2ace3ba14cf16f35ecafeec4feb33a82ff0edeb", "old_mode": 33188, "old_path": "dhcp/dhcp_provider_unittest.cc", "new_id": "98f5791606631202cadc7e8b4c55a69797b4b72c", "new_mode": 33188, "new_path": "dhcp/dhcp_provider_unittest.cc" }, { "type": "modify", "old_id": "4e3904584f333c0bdfd27b636ad8490be12233e7", "old_mode": 33188, "old_path": "dns_client.cc", "new_id": "195e16e18cd22771374201bee5efa532241cb097", "new_mode": 33188, "new_path": "dns_client.cc" }, { "type": "modify", "old_id": "4a236c4f755b27442b380aff2e5dfd3e16d6cd7a", "old_mode": 33188, "old_path": "dns_client_unittest.cc", "new_id": "16a6e4b7deb08b7183096cf39cf7340a353c95b3", "new_mode": 33188, "new_path": "dns_client_unittest.cc" }, { "type": "modify", "old_id": "8150352c256e1d12ac996d95a26745cc880da697", "old_mode": 33188, "old_path": "dns_server_tester.cc", "new_id": "66780bcb8aabca9ddc0d019d63240074c63650a3", "new_mode": 33188, "new_path": "dns_server_tester.cc" }, { "type": "modify", "old_id": "dac4ec7679d65a8b574cd778d4f82f9d15f1461c", "old_mode": 33188, "old_path": "dns_server_tester_unittest.cc", "new_id": "754e0efb4554788b0276a621a6c78384e674aa52", "new_mode": 33188, "new_path": "dns_server_tester_unittest.cc" }, { "type": "modify", "old_id": "588f62d0846088583c111b03a20e59513738678e", "old_mode": 33188, "old_path": "ethernet/ethernet.cc", "new_id": "1e24b5967d9bd8e6dc47fb6957cee7c3735c0b2a", "new_mode": 33188, "new_path": "ethernet/ethernet.cc" }, { "type": "modify", "old_id": "38cacb19e08394bc0b8c1c0079b87e2d239863cf", "old_mode": 33188, "old_path": "ethernet/ethernet_unittest.cc", "new_id": "3ae2acec24e2ee13ab6b10b47a1101afaa678755", "new_mode": 33188, "new_path": "ethernet/ethernet_unittest.cc" }, { "type": "modify", "old_id": "aed8c6a54e6535a8ceb79fc99b3a397040122f19", "old_mode": 33188, "old_path": "event_dispatcher.cc", "new_id": "cce27b1e1767d2fad1bcc7e294354af3c873a6a5", "new_mode": 33188, "new_path": "event_dispatcher.cc" }, { "type": "modify", "old_id": "85dc10dca695739b313abd9a9ec6574dea3e117d", "old_mode": 33188, "old_path": "event_dispatcher.h", "new_id": "b244d34c91b1fcefebba77af16ac8b32d1c917b2", "new_mode": 33188, "new_path": "event_dispatcher.h" }, { "type": "modify", "old_id": "14768ab3fea36401b670a223ec882ab7fb614fc2", "old_mode": 33188, "old_path": "external_task.cc", "new_id": "8e71ee885fcd2ebfaa45b5450da9b791673e7c10", "new_mode": 33188, "new_path": "external_task.cc" }, { "type": "modify", "old_id": "0dfc51250f9375e43051cd7cc49f68a885158fdc", "old_mode": 33188, "old_path": "hook_table.cc", "new_id": "0139c943dfcbb018403fe472c34b07ac470a3515", "new_mode": 33188, "new_path": "hook_table.cc" }, { "type": "modify", "old_id": "dc479388a399aa0bdf4b2e2ec54ddd859d0d76c5", "old_mode": 33188, "old_path": "hook_table_unittest.cc", "new_id": "964151fdb4bc4e07e86ea1650293bad9d987cada", "new_mode": 33188, "new_path": "hook_table_unittest.cc" }, { "type": "modify", "old_id": "015146c16766e22e21cde0c61738ccdd727003c4", "old_mode": 33188, "old_path": "http_request.cc", "new_id": "0d59752152df56f3ab5b1c13fab0fd5bad6a3eca", "new_mode": 33188, "new_path": "http_request.cc" }, { "type": "modify", "old_id": "dc1f4c6bfe7f839553a41dbd5b3ddd0c31d82fa4", "old_mode": 33188, "old_path": "http_request_unittest.cc", "new_id": "586eb740c486c847ab7ed9f1ef4cc82e4dbc2eb8", "new_mode": 33188, "new_path": "http_request_unittest.cc" }, { "type": "modify", "old_id": "ce7a8d219f140784d9f77362de3a312aad419621", "old_mode": 33188, "old_path": "icmp_session.cc", "new_id": "b036e12bc5f4c8c8c106c40e8636142e3b1a9dbb", "new_mode": 33188, "new_path": "icmp_session.cc" }, { "type": "modify", "old_id": "f5421aee955dcddf15eb5d6a9ce0b2279b8d0f40", "old_mode": 33188, "old_path": "icmp_session_unittest.cc", "new_id": "86f0887031bd9ec6c25d5a8f9a5655309b311253", "new_mode": 33188, "new_path": "icmp_session_unittest.cc" }, { "type": "modify", "old_id": "3318dc5a442a260b9c80402eaffb005590d1f98c", "old_mode": 33188, "old_path": "manager.cc", "new_id": "9d1963dd5ce6272e14c8ea623b4aa849cb9cbbf9", "new_mode": 33188, "new_path": "manager.cc" }, { "type": "modify", "old_id": "396ff496775213fa98e296657dce7e60ea2e18c8", "old_mode": 33188, "old_path": "mock_event_dispatcher.h", "new_id": "9e81b58317f77a7d9ed8649cee21cd3c91c0e016", "new_mode": 33188, "new_path": "mock_event_dispatcher.h" }, { "type": "modify", "old_id": "ae6953187360dce7a3caaa25c53022aae8d7d78f", "old_mode": 33188, "old_path": "passive_link_monitor.cc", "new_id": "9cbe7f8bc1a028c8cf5be9971c42597c7bc131d8", "new_mode": 33188, "new_path": "passive_link_monitor.cc" }, { "type": "modify", "old_id": "62cbb6b26c91629136f5d7bf2a960fbab2328d47", "old_mode": 33188, "old_path": "passive_link_monitor_unittest.cc", "new_id": "89c79fd03639db629fe1801c2f4722c381cbf89f", "new_mode": 33188, "new_path": "passive_link_monitor_unittest.cc" }, { "type": "modify", "old_id": "e86c189863b8d72ec9493866fad1dfe95c96a8bf", "old_mode": 33188, "old_path": "process_manager.cc", "new_id": "6d9649f198d3193f79cff5593c5354b9ca68ec9f", "new_mode": 33188, "new_path": "process_manager.cc" }, { "type": "modify", "old_id": "150d28fd37bea35fc7c4a3354b256d4151715973", "old_mode": 33188, "old_path": "result_aggregator.cc", "new_id": "475757c076a9c878d0b2962eafa59ddc56467c66", "new_mode": 33188, "new_path": "result_aggregator.cc" }, { "type": "modify", "old_id": "fa903fe3658a80361ccf3f15999eab9f3158132a", "old_mode": 33188, "old_path": "result_aggregator_unittest.cc", "new_id": "4ca42dc93818687235def71974a2eeadf5085a07", "new_mode": 33188, "new_path": "result_aggregator_unittest.cc" }, { "type": "modify", "old_id": "37d2224bba8336e110c14d08ff20f7ce0b24e09c", "old_mode": 33188, "old_path": "service.cc", "new_id": "33dc615aad2fab9272f1972a89f40882fa200717", "new_mode": 33188, "new_path": "service.cc" }, { "type": "modify", "old_id": "8a4430179bf17135a2c75f0e5c0256b5dcfa0dd1", "old_mode": 33188, "old_path": "service_unittest.cc", "new_id": "bf65ed3cc99523af4e6edc763ff260dbe997c831", "new_mode": 33188, "new_path": "service_unittest.cc" }, { "type": "modify", "old_id": "18f7f04a418ac7c9d8c1c487a00302b86d9a3769", "old_mode": 33188, "old_path": "traffic_monitor.cc", "new_id": "af1af2a95b6acb0e29a88e2d264e8ee2c80f9cac", "new_mode": 33188, "new_path": "traffic_monitor.cc" }, { "type": "modify", "old_id": "5bac7d103789f987c66574eafabf2206c41cfe27", "old_mode": 33188, "old_path": "vpn/l2tp_ipsec_driver_unittest.cc", "new_id": "fbbc9067cf64e7815f3e65c0e6d8e8f161747f1d", "new_mode": 33188, "new_path": "vpn/l2tp_ipsec_driver_unittest.cc" }, { "type": "modify", "old_id": "24d5c281c37c30c6626a88791ebc73e165a77907", "old_mode": 33188, "old_path": "vpn/openvpn_driver_unittest.cc", "new_id": "346af84f9f1d49302f7c460e6a92e6d2847f370f", "new_mode": 33188, "new_path": "vpn/openvpn_driver_unittest.cc" }, { "type": "modify", "old_id": "dfbc5744bc6933ce1d9a2109dfaa9da1eec1f81a", "old_mode": 33188, "old_path": "vpn/vpn_driver.cc", "new_id": "8b6b3797a8fea84bb0a7ad23ae86c53bacbf62cd", "new_mode": 33188, "new_path": "vpn/vpn_driver.cc" }, { "type": "modify", "old_id": "04fc17cdfdb7c166997d856cf2068ceb4c93ec72", "old_mode": 33188, "old_path": "wifi/mac80211_monitor.cc", "new_id": "87d65d9b050820a363a4dc66b796190d29682c62", "new_mode": 33188, "new_path": "wifi/mac80211_monitor.cc" }, { "type": "modify", "old_id": "935293756c28b7eb1985292348dc1a40cd4638ba", "old_mode": 33188, "old_path": "wifi/mac80211_monitor_unittest.cc", "new_id": "70d343ac015101bb607331561a8145e3a48844cd", "new_mode": 33188, "new_path": "wifi/mac80211_monitor_unittest.cc" }, { "type": "modify", "old_id": "67651f43401501e61f6db08a4a7c959777a25678", "old_mode": 33188, "old_path": "wifi/tdls_manager.cc", "new_id": "b294c7aa0e3d78b94a70bbab36404db3e7d32d05", "new_mode": 33188, "new_path": "wifi/tdls_manager.cc" }, { "type": "modify", "old_id": "95962578863694f13325b269c460cefcb743fb1c", "old_mode": 33188, "old_path": "wifi/tdls_manager_unittest.cc", "new_id": "18c49283165f5bb41c2f943b69db1266c1d70f03", "new_mode": 33188, "new_path": "wifi/tdls_manager_unittest.cc" }, { "type": "modify", "old_id": "26ec6f384cd1be9ec4ebdb0b3b6060f5777dd9e7", "old_mode": 33188, "old_path": "wifi/wake_on_wifi.cc", "new_id": "83bf10add5d70523392c81c6830d3de9ff532f12", "new_mode": 33188, "new_path": "wifi/wake_on_wifi.cc" }, { "type": "modify", "old_id": "574804cd501b102bcc3eb8e6bdce47c96386e1b2", "old_mode": 33188, "old_path": "wifi/wake_on_wifi_unittest.cc", "new_id": "56e9587ec6a0867484240aced3062f45e64e2690", "new_mode": 33188, "new_path": "wifi/wake_on_wifi_unittest.cc" }, { "type": "modify", "old_id": "ef3c8af086d8f85dfafef255b4e3146d9139e32f", "old_mode": 33188, "old_path": "wifi/wifi.cc", "new_id": "4d94f24e9ce5d6a93202160c6fd3c07c6b10bcb0", "new_mode": 33188, "new_path": "wifi/wifi.cc" }, { "type": "modify", "old_id": "342456e0137014fd5a685e49524ca622a551869f", "old_mode": 33188, "old_path": "wifi/wifi_unittest.cc", "new_id": "e099e32e5b5072092552295d44f2612cb927c9dc", "new_mode": 33188, "new_path": "wifi/wifi_unittest.cc" }, { "type": "modify", "old_id": "4dc738cdd2e224d2842ea8c89cef8041bdc28b0f", "old_mode": 33188, "old_path": "wimax/wimax.cc", "new_id": "524e63f1ddfeebb3344c2772a0a2eddcf94636dd", "new_mode": 33188, "new_path": "wimax/wimax.cc" } ] }