shill: Add OpenVPN peer and subnet addresses to per-device routing tables
In split tunnel configurations, OpenVPN can push a number of different
IP addresses depending on the --topology setting:
- A peer address (tun0 point-to-point IP)
- A subnet range (e.g. 192.168.1.0/24)
- A default gateway address (next hop)
- Per-route gateway addresses
Add explicit routes to |properties->routes| for the former two items.
Ignore all gateway addresses: they aren't needed in order to send
traffic out through tun0, and if they're wrong, they can cause the
kernel to reject the route. Instead, specify the local IP as the
gateway for each route.
Also, change IgnoreDefaultRoute so that it makes shill ignore the
redirect-gateway option. In the past it was usually necessary to
specify this option in order to make split tunnel VPNs work properly,
but it shouldn't be necessary anymore.
BUG=chromium:370460
BUG=chromium:821236
TEST=manually test net30, p2p, and subnet toplogies with and without
redirect-gateway and pushed routes
Change-Id: I73818b21111acf6739defb7337e84c0888567868
Reviewed-on: https://chromium-review.googlesource.com/967564
Commit-Ready: Kevin Cernekee <cernekee@chromium.org>
Tested-by: Kevin Cernekee <cernekee@chromium.org>
Reviewed-by: Abhishek Bhardwaj <abhishekbh@chromium.org>
Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org>
(cherry picked from commit b341a0f6552dcf6e48ca4829bdae3c88a5be7a23)
2 files changed
