)]}' { "commit": "8c5999637c7dcba715c93641e988ba5204caf7fa", "tree": "259dc0211e5d6848ce56e13e142045adcc2eb8d1", "parents": [ "827c00d7d5d8b839a84ddb138f0f833648d91b9a" ], "author": { "name": "Jan Wyszynski", "email": "wyszynski@google.com", "time": "Tue Aug 16 00:46:35 2016" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Tue Dec 06 00:42:56 2016" }, "message": "Revise firewalld unittests\n\nPreviously, unit tests for firewalld in iptables_unittest.cc\nwere tightly coupled with the implementation of IpTables::ApplyVpnSetup\nmaking them difficult to maintain when changes to the daemon were\nintroduced. This commit augments the MockIpTables class by mocking\nExecvNonRoot and keeping track of the ip/iptables shell commands that\nare issued during a test. This makes it possible to test that error\ncases properly handle undo-ing the addition of any firewall rules\nthat are added during IpTables::ApplyVpnSetup.\n\nBUG\u003dNone\nTEST\u003dNone\nChange-Id: Ibfd581ebaad55826d95bdc3b5ad98795610aee9f\nReviewed-on: https://chromium-review.googlesource.com/370862\nCommit-Ready: Kevin Cernekee \u003ccernekee@chromium.org\u003e\nTested-by: Ian Wyszynski \u003cwyszynski@google.com\u003e\nReviewed-by: Ian Wyszynski \u003cwyszynski@google.com\u003e\nReviewed-by: Kevin Cernekee \u003ccernekee@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "7fc96da8666cef40a450eede383d7f7d1f5b8bfa", "old_mode": 33188, "old_path": "iptables.cc", "new_id": "992df582cbea1b765c99a7c7f5d3ce068eed600a", "new_mode": 33188, "new_path": "iptables.cc" }, { "type": "modify", "old_id": "74b9acb6610242e90c47b4fd8866a750c58f1357", "old_mode": 33188, "old_path": "iptables.h", "new_id": "beca79c720aa6443fbdb9ddb5d62a8dc2d52e694", "new_mode": 33188, "new_path": "iptables.h" }, { "type": "modify", "old_id": "615b4f85a7d490ee20d75b95db3e8d2e8afbc1bf", "old_mode": 33188, "old_path": "iptables_unittest.cc", "new_id": "bb3cff6f3a3a51fa4f65715bf05ae224a84ef803", "new_mode": 33188, "new_path": "iptables_unittest.cc" }, { "type": "modify", "old_id": "767637f520ef35c7daa7aab48b63fc5f5d49e1b9", "old_mode": 33188, "old_path": "mock_iptables.cc", "new_id": "8fe817b9f41c4624c02231a96d1c19eaa7c8d4e4", "new_mode": 33188, "new_path": "mock_iptables.cc" }, { "type": "modify", "old_id": "54aaa25e7a4810c3bcf4d1937ab86c819a561746", "old_mode": 33188, "old_path": "mock_iptables.h", "new_id": "cb0b5dfcbd0fb5c120e8878fe4f8f131666ab105", "new_mode": 33188, "new_path": "mock_iptables.h" } ] }