update_engine: Accumulate functions into OmahaRequestBuilderXml class.

Convert functions within relation to GetRequestXml into
OmahaRequestBuilderXml class.
The refactoring allows for a complete encapsulation of
required parameters to build the omaha request in xml format.

The vision for OmahaRequestBuilder is an interface that
opens up the possibility to create classes for building
various formats of omaha requests (i.e. OmahaRequestBuilderJson).

BUG=chromium:940505
TEST=cros_workon_make --board=octopus update_engine --test
TEST=/usr/bin/update_engine_client --check_for_update # after bouncing update-engine + check /var/log/update_engine.log.

Change-Id: I0b4501288fbf7127fc39513ef61b4ab4f8ceebd5
Reviewed-on: https://chromium-review.googlesource.com/1648075
Tested-by: Jae Hoon Kim <kimjae@chromium.org>
Commit-Ready: Jae Hoon Kim <kimjae@chromium.org>
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
Reviewed-by: Amin Hassani <ahassani@chromium.org>
4 files changed
tree: 1e0ff96a1688291bc3ba192bf9268b7ed2d93bb9
  1. .clang-format
  2. .gitignore
  3. Android.bp
  4. BUILD.gn
  5. COMMIT-QUEUE.ini
  6. CPPLINT.cfg
  7. MODULE_LICENSE_APACHE2
  8. NOTICE
  9. OWNERS
  10. PRESUBMIT.cfg
  11. PREUPLOAD.cfg
  12. UpdateEngine.conf
  13. binder_bindings/
  14. binder_service_android.cc
  15. binder_service_android.h
  16. binder_service_brillo.cc
  17. binder_service_brillo.h
  18. boot_control_android.cc
  19. boot_control_android.h
  20. boot_control_android_unittest.cc
  21. boot_control_chromeos.cc
  22. boot_control_chromeos.h
  23. boot_control_chromeos_unittest.cc
  24. certificate_checker.cc
  25. certificate_checker.h
  26. certificate_checker_unittest.cc
  27. chrome_browser_proxy_resolver.cc
  28. chrome_browser_proxy_resolver.h
  29. client-headers/
  30. client_library/
  31. common/
  32. common_service.cc
  33. common_service.h
  34. common_service_unittest.cc
  35. connection_manager.cc
  36. connection_manager.h
  37. connection_manager_android.cc
  38. connection_manager_android.h
  39. connection_manager_interface.h
  40. connection_manager_unittest.cc
  41. connection_utils.cc
  42. connection_utils.h
  43. daemon.cc
  44. daemon.h
  45. daemon_state_android.cc
  46. daemon_state_android.h
  47. daemon_state_interface.h
  48. dbus_bindings/
  49. dbus_connection.cc
  50. dbus_connection.h
  51. dbus_service.cc
  52. dbus_service.h
  53. dbus_test_utils.h
  54. dlcservice_chromeos.cc
  55. dlcservice_chromeos.h
  56. dynamic_partition_control_android.cc
  57. dynamic_partition_control_android.h
  58. dynamic_partition_control_interface.h
  59. fake_file_writer.h
  60. fake_p2p_manager.h
  61. fake_p2p_manager_configuration.h
  62. fake_shill_proxy.cc
  63. fake_shill_proxy.h
  64. fake_system_state.cc
  65. fake_system_state.h
  66. fuzz/
  67. generate_pc_file.sh
  68. hardware_android.cc
  69. hardware_android.h
  70. hardware_chromeos.cc
  71. hardware_chromeos.h
  72. hardware_chromeos_unittest.cc
  73. image_properties.h
  74. image_properties_android.cc
  75. image_properties_android_unittest.cc
  76. image_properties_chromeos.cc
  77. image_properties_chromeos_unittest.cc
  78. init/
  79. libcurl_http_fetcher.cc
  80. libcurl_http_fetcher.h
  81. local_coverage_rate
  82. main.cc
  83. metrics_constants.h
  84. metrics_reporter_android.cc
  85. metrics_reporter_android.h
  86. metrics_reporter_interface.h
  87. metrics_reporter_omaha.cc
  88. metrics_reporter_omaha.h
  89. metrics_reporter_omaha_unittest.cc
  90. metrics_reporter_stub.cc
  91. metrics_reporter_stub.h
  92. metrics_utils.cc
  93. metrics_utils.h
  94. metrics_utils_unittest.cc
  95. mock_boot_control_hal.h
  96. mock_certificate_checker.h
  97. mock_connection_manager.h
  98. mock_dynamic_partition_control.h
  99. mock_file_writer.h
  100. mock_metrics_reporter.h
  101. mock_omaha_request_params.h
  102. mock_p2p_manager.h
  103. mock_payload_state.h
  104. mock_power_manager.h
  105. mock_service_observer.h
  106. mock_update_attempter.h
  107. network_selector.h
  108. network_selector_android.cc
  109. network_selector_android.h
  110. network_selector_interface.h
  111. network_selector_stub.cc
  112. network_selector_stub.h
  113. omaha_request_action.cc
  114. omaha_request_action.h
  115. omaha_request_action_fuzzer.cc
  116. omaha_request_action_unittest.cc
  117. omaha_request_builder_xml.cc
  118. omaha_request_builder_xml.h
  119. omaha_request_builder_xml_unittest.cc
  120. omaha_request_params.cc
  121. omaha_request_params.h
  122. omaha_request_params_unittest.cc
  123. omaha_response.h
  124. omaha_response_handler_action.cc
  125. omaha_response_handler_action.h
  126. omaha_response_handler_action_unittest.cc
  127. omaha_utils.cc
  128. omaha_utils.h
  129. omaha_utils_unittest.cc
  130. p2p_manager.cc
  131. p2p_manager.h
  132. p2p_manager_unittest.cc
  133. parcelable_update_engine_status.cc
  134. parcelable_update_engine_status.h
  135. parcelable_update_engine_status_unittest.cc
  136. payload_consumer/
  137. payload_generator/
  138. payload_state.cc
  139. payload_state.h
  140. payload_state_interface.h
  141. payload_state_unittest.cc
  142. power_manager_android.cc
  143. power_manager_android.h
  144. power_manager_chromeos.cc
  145. power_manager_chromeos.h
  146. power_manager_interface.h
  147. pylintrc
  148. real_system_state.cc
  149. real_system_state.h
  150. run_unittests
  151. sample_images/
  152. sample_omaha_v3_response.xml
  153. scripts/
  154. service_delegate_android_interface.h
  155. service_observer_interface.h
  156. shill_proxy.cc
  157. shill_proxy.h
  158. shill_proxy_interface.h
  159. sideload_main.cc
  160. system_state.h
  161. tar_bunzip2.gni
  162. test_http_server.cc
  163. test_subprocess.cc
  164. testrunner.cc
  165. unittest_key.pem
  166. unittest_key2.pem
  167. update_attempter.cc
  168. update_attempter.h
  169. update_attempter_android.cc
  170. update_attempter_android.h
  171. update_attempter_android_unittest.cc
  172. update_attempter_unittest.cc
  173. update_boot_flags_action.cc
  174. update_boot_flags_action.h
  175. update_boot_flags_action_unittest.cc
  176. update_engine.conf
  177. update_engine.rc
  178. update_engine/
  179. update_engine_client.cc
  180. update_engine_client_android.cc
  181. update_manager/
  182. update_metadata.proto
  183. update_payload_key/
  184. update_status_utils.cc
  185. update_status_utils.h