| commit | 6e4de326034e0da70084e232095f92ad1a9437e7 | [log] [tgz] |
|---|---|---|
| author | Mike Frysinger <vapier@chromium.org> | Wed Aug 23 06:16:43 2017 |
| committer | Mike Frysinger <vapier@chromium.org> | Fri Aug 25 02:15:12 2017 |
| tree | 0e4831946cd077b86756d11f4aa1925cfb70d300 | |
| parent | 9cb0c414a6c3dc7920f8e3a04cd9050c29986cf8 [diff] |
hterm: fix OSC termination edge cases Our OSC sequences may be terminated by either \a or a string terminator (ST) \e\\. However, the current logic requires that the ST be in the same buffer. If the lower layers happen to split the buffer such that the first buffer ends with the \e and the next buffer starts with a \\, we end up rejecting it because we saw the plain \e. Normally this does not happen, but with a large series of OSC sequences, it's easy to get ssh buffering to split it up on us. While sorting this out, we find the current logic also skips over any embedded escapes in a buffer if there is a valid ST sequence in there. We should be rejecting those too. While debugging this, we notice that the timeout logic does not work correctly either. Due to order of operations, the string/date/math creates a NaN which fails the abortReason test since NaN is falsey. BUG=chromium:212700 Change-Id: I1c94a300f4afaf2c62fa122d8365d1a4dc209229 Reviewed-on: https://chromium-review.googlesource.com/627842 Reviewed-by: Brandon Gilmore <varz@google.com> Tested-by: Mike Frysinger <vapier@chromium.org>
This repository contains the libdot JavaScript library and some web applications that make use of it.
The official copy of this repository is hosted at https://chromium.googlesource.com/apps/libapps.
There is also a mirror on github at https://github.com/libapps/libapps-mirror. Keep in mind that this mirror may occasionally be behind the official repository.
All changes must go through the Gerrit code review server on https://chromium-review.googlesource.com. Github pull requests cannot be accepted. Please see the HACK.md document in this directory for the details.
libdot/ is a small set of JS libraries initially developed as part of hterm, now available as shared code. It provides a base layer for web applications. The code is intended to work in any modern browser, in either a plain web page or a “privileged” environment such as a Chrome platform application or Firefox extension. In practice, it's only been put to use in Chrome platform applications so far.
hterm/ is a JS library that provides a terminal emulator. It is reasonably fast, reasonably correct, and reasonably portable across browsers.
nassh/ is the Secure Shell Chrome App (currently a “v1.5” app, soon to become a “v2” or platform app) that combines hterm with a NaCl build of OpenSSH to provide a PuTTY-like app for Chrome users.
ssh_client/ is the NaCl port of OpenSSH. It is used by nassh to create the Secure Shell App.
wash/ is a library for cross-origin virtual filesystems, similar to the Plan 9 filesystem. This directory also contains a simple bash-like shell environment for exploring these filesystems. The code in this directory is a work-in-progress.