nassh: crosh: fix opening in window from a tab

The lib.f.openWindow API works if the current session is already in a
window.  If it's in a tab, then Chrome (for some reason) blocks using
chrome=no in the window.open call.  For crosh, we can assume we have
access to Chrome APIs as this only runs on CrOS, so use chrome.windows
to get guarantee opening as a new window.

Change-Id: I644eb12dcd5fdf2c0aa3e8a3ced6bbad4406f8f1
Reviewed-on: https://chromium-review.googlesource.com/c/1495414
Reviewed-by: Vitaliy Shipitsyn <vsh@google.com>
Tested-by: Mike Frysinger <vapier@chromium.org>
1 file changed
tree: 565aca8040b4361153cc64a9170cc1d9fba10fc7
  1. hterm/
  2. libdot/
  3. nassh/
  4. saltpig/
  5. ssh_client/
  6. wam/
  7. wash/
  8. .clang-format
  9. .eslintrc.js
  10. .gitignore
  11. .pylintrc
  12. Dockerfile
  13. HACK.md
  14. LICENSE
  15. navbar.md
  16. package.json
  17. README.md
README.md

Hello

This repository contains the libdot JavaScript library and some web applications that make use of it.

The official copy of this repository is hosted at https://chromium.googlesource.com/apps/libapps.

There is also a mirror on github at https://github.com/libapps/libapps-mirror. A few subprojects are also extracted out into their own git repo and mirrored. Keep in mind that these mirrors may occasionally be behind the official repository.

All changes must go through the Gerrit code review server on https://chromium-review.googlesource.com. Github pull requests cannot be accepted. Please see the HACK.md document in this directory for the details.

Top level directories

  • libdot/ is a small set of JS libraries initially developed as part of hterm, now available as shared code.

  • hterm/ is a JS library that provides a terminal emulator. It is reasonably fast, reasonably correct, and reasonably portable across browsers.

  • nassh/ is the Secure Shell Chrome App (currently a “v1.5” app, soon to become a “v2” or platform app) that combines hterm with a NaCl build of OpenSSH to provide a PuTTY-like app for Chrome users.

  • ssh_client/ is the NaCl port of OpenSSH. It is used by nassh to create the Secure Shell App.

  • wash/ is a library for cross-origin virtual filesystems, similar to the Plan 9 filesystem. This directory also contains a simple bash-like shell environment for exploring these filesystems. The code in this directory is a work-in-progress.