hterm: Only announce a space character if it is the character actually printed to the screen

Currently the heuristic for announcing space characters just examines
the last character behind the cursor. But when doing things like a bash
reverse search, the cursor will move relative to a space character
without a space character being entered and space will be announced.

This adds a requirement for a space character to be announced only if
it is printed to the screen.

Bug: 822490, 646690
Change-Id: I6c2a6c7ebd5edcb12af4bc6d11b89b52eac52be6
Reviewed-on: https://chromium-review.googlesource.com/1139839
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Tested-by: Raymes Khoury <raymes@chromium.org>
2 files changed
tree: 10ad156ccb4d714a60fa9dbc91781f91326576d0
  1. hterm/
  2. libdot/
  3. nassh/
  4. saltpig/
  5. ssh_client/
  6. wam/
  7. wash/
  8. .clang-format
  9. .eslintrc.js
  10. .gitignore
  11. HACK.md
  12. LICENSE
  13. navbar.md
  14. package.json
  15. README.md
README.md

Hello

This repository contains the libdot JavaScript library and some web applications that make use of it.

The official copy of this repository is hosted at https://chromium.googlesource.com/apps/libapps.

There is also a mirror on github at https://github.com/libapps/libapps-mirror. A few subprojects are also extracted out into their own git repo and mirrored. Keep in mind that these mirrors may occasionally be behind the official repository.

All changes must go through the Gerrit code review server on https://chromium-review.googlesource.com. Github pull requests cannot be accepted. Please see the HACK.md document in this directory for the details.

Top level directories

  • libdot/ is a small set of JS libraries initially developed as part of hterm, now available as shared code.

  • hterm/ is a JS library that provides a terminal emulator. It is reasonably fast, reasonably correct, and reasonably portable across browsers.

  • nassh/ is the Secure Shell Chrome App (currently a “v1.5” app, soon to become a “v2” or platform app) that combines hterm with a NaCl build of OpenSSH to provide a PuTTY-like app for Chrome users.

  • ssh_client/ is the NaCl port of OpenSSH. It is used by nassh to create the Secure Shell App.

  • wash/ is a library for cross-origin virtual filesystems, similar to the Plan 9 filesystem. This directory also contains a simple bash-like shell environment for exploring these filesystems. The code in this directory is a work-in-progress.