| commit | 859bcbd8a89c3048677a533bcb798eb7fb5aabd3 | [log] [tgz] |
|---|---|---|
| author | Mike Frysinger <vapier@chromium.org> | Tue Aug 29 03:48:43 2017 |
| committer | Mike Frysinger <vapier@chromium.org> | Fri Sep 01 22:21:28 2017 |
| tree | a18264111cfbf712c877ea9d7175b5ac27fb0f28 | |
| parent | e7fe13dfb4e8ec4e5b8b6eb61ebb47bf88f5479a [diff] |
hterm: fix replacing wide chars with narrow chars We handled backing up over wide chars when processing them in their entirety, but our edge case checking missed deleting a single column in the right half of the character (where offset is not zero in the first loop iteration). The count math would then go negative and we'd loop forever as we only stop when count hits zero. Add another edge case check for this, and add a sanity check for the count so we at least don't loop forever if there's another bug. We change an existing test's expectations to match the new behavior: if we have a wide character, and the cursor is in the middle of it, and we issue an erase-to-the-right command, the first column of the wide character should be turned into a space. Before, we would also delete it. Logically this makes more sense as the cursor location is a fixed coordinate, so deleting a wide character should not cause it to also move to the left by a column. BUG=chromium:577691 Change-Id: Iafc3510489dcc88f4284d4cbea663b4b973fc1b7 Reviewed-on: https://chromium-review.googlesource.com/641372 Reviewed-by: Rob Ginda <rginda@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org>
This repository contains the libdot JavaScript library and some web applications that make use of it.
The official copy of this repository is hosted at https://chromium.googlesource.com/apps/libapps.
There is also a mirror on github at https://github.com/libapps/libapps-mirror. Keep in mind that this mirror may occasionally be behind the official repository.
All changes must go through the Gerrit code review server on https://chromium-review.googlesource.com. Github pull requests cannot be accepted. Please see the HACK.md document in this directory for the details.
libdot/ is a small set of JS libraries initially developed as part of hterm, now available as shared code. It provides a base layer for web applications. The code is intended to work in any modern browser, in either a plain web page or a “privileged” environment such as a Chrome platform application or Firefox extension. In practice, it's only been put to use in Chrome platform applications so far.
hterm/ is a JS library that provides a terminal emulator. It is reasonably fast, reasonably correct, and reasonably portable across browsers.
nassh/ is the Secure Shell Chrome App (currently a “v1.5” app, soon to become a “v2” or platform app) that combines hterm with a NaCl build of OpenSSH to provide a PuTTY-like app for Chrome users.
ssh_client/ is the NaCl port of OpenSSH. It is used by nassh to create the Secure Shell App.
wash/ is a library for cross-origin virtual filesystems, similar to the Plan 9 filesystem. This directory also contains a simple bash-like shell environment for exploring these filesystems. The code in this directory is a work-in-progress.