hterm: fix handling of inverse text with true colors

The text attribute code would update the foreground/background colors
only when they weren't already in true color form.  This was somewhat
intentional in that updates to the color (like bolding and faint) are
for non-true color sources, but it unintentionally missed flipping the
foreground & background colors when inverse is active.

We fix this by not writing directly to the foreground/background attrs
when setting true colors.  This lets us always treat them as outputs
by the sync code.  Instead, we continue using the "source" attrs like
we do for the palette based colors.  This lets us drop the SRC_RGB
constant as there are no more users.

BUG=chromium:736025

Change-Id: Id10ffcefcbac69d0d920de12cac910065d8902a5
Reviewed-on: https://chromium-review.googlesource.com/765590
Reviewed-by: Brandon Gilmore <varz@google.com>
Tested-by: Mike Frysinger <vapier@chromium.org>
3 files changed
tree: f9427f5006108555e0e3638061ad6b0469169ebe
  1. hterm/
  2. libdot/
  3. nassh/
  4. saltpig/
  5. ssh_client/
  6. wam/
  7. wash/
  8. .gitignore
  9. HACK.md
  10. LICENSE
  11. package.json
  12. README.md
README.md

Hello

This repository contains the libdot JavaScript library and some web applications that make use of it.

The official copy of this repository is hosted at https://chromium.googlesource.com/apps/libapps.

There is also a mirror on github at https://github.com/libapps/libapps-mirror. Keep in mind that this mirror may occasionally be behind the official repository.

All changes must go through the Gerrit code review server on https://chromium-review.googlesource.com. Github pull requests cannot be accepted. Please see the HACK.md document in this directory for the details.

Top level directories

  • libdot/ is a small set of JS libraries initially developed as part of hterm, now available as shared code. It provides a base layer for web applications. The code is intended to work in any modern browser, in either a plain web page or a “privileged” environment such as a Chrome platform application or Firefox extension. In practice, it's only been put to use in Chrome platform applications so far.

  • hterm/ is a JS library that provides a terminal emulator. It is reasonably fast, reasonably correct, and reasonably portable across browsers.

  • nassh/ is the Secure Shell Chrome App (currently a “v1.5” app, soon to become a “v2” or platform app) that combines hterm with a NaCl build of OpenSSH to provide a PuTTY-like app for Chrome users.

  • ssh_client/ is the NaCl port of OpenSSH. It is used by nassh to create the Secure Shell App.

  • wash/ is a library for cross-origin virtual filesystems, similar to the Plan 9 filesystem. This directory also contains a simple bash-like shell environment for exploring these filesystems. The code in this directory is a work-in-progress.