| commit | 02dd5c3ffbfed2bcbc93b553ed0e90a1ac951cb4 | [log] [tgz] |
|---|---|---|
| author | Leonard Grey <lgrey@chromium.org> | Mon Dec 02 17:44:04 2024 |
| committer | Leonard Grey <lgrey@chromium.org> | Mon Dec 02 20:35:37 2024 |
| tree | fd495bf76eec862ce3f5e8a1910351e24a4828d1 | |
| parent | 1db382f0dabe2d17f49956066286e4bf15482b5a [diff] |
Upload system symbols: ensure dumped breakpad filenames are unique At some point, we started hitting limits on symbol file names, so we began collapsing each path components except the filename down to the first letter. This breaks down with the following setup: Some.framework/Versions/30/libSomething.dylib Some.framework/Versions/31/libSomething.dylib Which collapse to the same file name. Since upload_system_symbols dumps in parallel, this can lead to one of the files overwriting part of the other, creating a corrupted end product. This change creates files with O_EXCL. If creating fails due to the file already existing, we tack on a counter (so f.sym becomes f_1.sym, for example). Bug: chromium:40250422 Change-Id: I66ea50b84d68d3c5103eb7e31568b8444ec3be27 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/6064141 Reviewed-by: Mark Mentovai <mark@chromium.org>
Breakpad is a set of client and server components which implement a crash-reporting system.
First, download depot_tools and ensure that they’re in your PATH.
Create a new directory for checking out the source code (it must be named breakpad).
mkdir breakpad && cd breakpad
Run the fetch tool from depot_tools to download all the source repos.
fetch breakpad
cd src
Build the source.
./configure && make
You can also cd to another directory and run configure from there to build outside the source tree.
This will build the processor tools (src/processor/minidump_stackwalk, src/processor/minidump_dump, etc), and when building on Linux it will also build the client libraries and some tools (src/tools/linux/dump_syms/dump_syms, src/tools/linux/md2core/minidump-2-core, etc).
Optionally, run tests.
make check
Optionally, install the built libraries
make install
If you need to reconfigure your build be sure to run make distclean first.
To update an existing checkout to a newer revision, you can git pull as usual, but then you should run gclient sync to ensure that the dependent repos are up-to-date.
Follow the steps above to get the source and build it.
Make changes. Build and test your changes. For core code like processor use methods above. For linux/mac/windows, there are test targets in each project file.
Commit your changes to your local repo and upload them to the server. http://dev.chromium.org/developers/contributing-code e.g. git commit ... && git cl upload ... You will be prompted for credential and a description.
At https://chromium-review.googlesource.com/ you'll find your issue listed; click on it, then “Add reviewer”, and enter in the code reviewer. Depending on your settings, you may not see an email, but the reviewer has been notified with google-breakpad-dev@googlegroups.com always CC’d.