commit | 0808030bee8bc88a34675cd1dd83b965a2249a08 | [log] [tgz] |
---|---|---|
author | Iryna Shakhova <irinasha@google.com> | Thu May 12 09:32:52 2022 |
committer | Joshua Peraza <jperaza@chromium.org> | Thu May 12 18:24:10 2022 |
tree | 62195e5e5fab16ecb0380121a5b187be4a6b2f2a | |
parent | c85eb4a59b618f3beaad5445ceb1f865ffa8efdf [diff] |
Support PE modules in core files when running core2md Core files generated from `wine` contain both ELF and PE modules. Module format can be guessed by checking the file contents. If the module corresponds to PE-file conditions (has specific fields set up as described in https://code.google.com/archive/p/corkami/wikis/PE.wiki) we'll create a MDCVInfoPDB70 record in the minidump for it, but if the file cannot be opened, is too short or is not a PE file, we'll fall back to ELF procedure. Added /src/client/linux/minidump_writer/pe_file.{cc,h} to src_client_linux_libbreakpad_client_a_SOURCES and src_client_linux_linux_client_unittest_shlib_SOURCES. Makefile.in and aclocal.m4 were generated by running 'aclocal && automake'. Test: build core2md and use it to convert a core file into dmp, validate that the generated dmp file can be opened. Ran './configure & make'. Change-Id: I225ffeea3f582deed40ecdfe7ab77f5754e90cbe Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3629189 Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Breakpad is a set of client and server components which implement a crash-reporting system.
First, download depot_tools and ensure that they’re in your PATH
.
Create a new directory for checking out the source code (it must be named breakpad).
mkdir breakpad && cd breakpad
Run the fetch
tool from depot_tools to download all the source repos.
fetch breakpad
cd src
Build the source.
./configure && make
You can also cd to another directory and run configure from there to build outside the source tree.
This will build the processor tools (src/processor/minidump_stackwalk
, src/processor/minidump_dump
, etc), and when building on Linux it will also build the client libraries and some tools (src/tools/linux/dump_syms/dump_syms
, src/tools/linux/md2core/minidump-2-core
, etc).
Optionally, run tests.
make check
Optionally, install the built libraries
make install
If you need to reconfigure your build be sure to run make distclean
first.
To update an existing checkout to a newer revision, you can git pull
as usual, but then you should run gclient sync
to ensure that the dependent repos are up-to-date.
Follow the steps above to get the source and build it.
Make changes. Build and test your changes. For core code like processor use methods above. For linux/mac/windows, there are test targets in each project file.
Commit your changes to your local repo and upload them to the server. http://dev.chromium.org/developers/contributing-code e.g. git commit ... && git cl upload ...
You will be prompted for credential and a description.
At https://chromium-review.googlesource.com/ you'll find your issue listed; click on it, then “Add reviewer”, and enter in the code reviewer. Depending on your settings, you may not see an email, but the reviewer has been notified with google-breakpad-dev@googlegroups.com always CC’d.