Revert "Allow symupload to take .sym files as input." This reverts commit d9e7473f6a2f572b6d78735199fee6f4f565554d. Reason for revert: Broken on Windows systems and is blocking uprev in Chromium as a result. https://crrev.com/c/7392920 as an example. src/tools/windows/symupload/symupload.cc(162,10): error: use of undeclared identifier 'GetModuleInfoFromSymFile' 162 | return GetModuleInfoFromSymFile(temp_filename, pdb_info); src/tools/windows/symupload/symupload.cc(191,56): error: no member named 'UTF8ToWide' in 'google_breakpad::WindowsStringUtils' 191 | pdb_info->cpu = google_breakpad::WindowsStringUtils::UTF8ToWide(cpu_str); Original change's description: > Allow symupload to take .sym files as input. > > This change enables symupload to directly process Breakpad symbol files (.sym). When a .sym file is provided, the module information (OS, CPU, debug ID, and filename) is extracted from the first line of the .sym file. The temporary file cleanup is also adjusted to only remove the generated .sym file when the input was not already a .sym file. > > Bug: 459506875 > Change-Id: I54c796733654aebf30528ac6eda6f0ca5b85378a > Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/7231157 > Reviewed-by: Mike Frysinger <vapier@chromium.org> > Reviewed-by: Joshua Peraza <jperaza@chromium.org> Bug: 459506875 Change-Id: I10b9adb3b0e9ec7c3b760da83025a586e64e9b8d Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/7474647 Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Breakpad is a set of client and server components which implement a crash-reporting system.
First, download depot_tools and ensure that they’re in your PATH.
Create a new directory for checking out the source code (it must be named breakpad).
mkdir breakpad && cd breakpad
Run the fetch tool from depot_tools to download all the source repos.
fetch breakpad
cd src
Build the source.
./configure && make
You can also cd to another directory and run configure from there to build outside the source tree.
This will build the processor tools (src/processor/minidump_stackwalk, src/processor/minidump_dump, etc), and when building on Linux it will also build the client libraries and some tools (src/tools/linux/dump_syms/dump_syms, src/tools/linux/md2core/minidump-2-core, etc).
Optionally, run tests.
make check
Optionally, install the built libraries
make install
If you need to reconfigure your build be sure to run make distclean first.
To update an existing checkout to a newer revision, you can git pull as usual, but then you should run gclient sync to ensure that the dependent repos are up-to-date.
Follow the steps above to get the source and build it.
Make changes. Build and test your changes. For core code like processor use methods above. For linux/mac/windows, there are test targets in each project file.
Commit your changes to your local repo and upload them to the server. http://dev.chromium.org/developers/contributing-code e.g. git commit ... && git cl upload ... You will be prompted for credential and a description.
At https://chromium-review.googlesource.com/ you'll find your issue listed; click on it, then “Add reviewer”, and enter in the code reviewer. Depending on your settings, you may not see an email, but the reviewer has been notified with google-breakpad-dev@googlegroups.com always CC’d.