commit | 2c03db146a6168c544f31d5454d7d36205b2baba | [log] [tgz] |
---|---|---|
author | Pavel Labath <labath@google.com> | Tue Jan 12 15:43:06 2016 |
committer | Mark Mentovai <mark@chromium.org> | Tue Jan 12 15:43:06 2016 |
tree | 2ed408ab5b8ccd8d8898254356cbaabd006a5135 | |
parent | 860d7f5da1895c47bd07aecfff0d907ab177ad4b [diff] |
libdisasm: Remove inclusion of windows.h windows.h defines exception_code as a macro, which conflicts with our use of the identifier in exception records. It appears that this particular include of windows.h is not needed, so instead of undefining the macro, I simply delete the include. Build tested with MSVC 2013. BUG= R=mark@chromium.org Review URL: https://codereview.chromium.org/1579623004 . Patch from Pavel Labath <labath@google.com>.
Breakpad is a set of client and server components which implement a crash-reporting system.
# Configure CXXFLAGS=-m32 CFLAGS=-m32 CPPFLAGS=-m32 ./configure # Build make # Test make check # Install make install
If you need to reconfigure your build be sure to run make distclean
first.
Get a copy of depot_tools repo. http://dev.chromium.org/developers/how-tos/install-depot-tools
Create a new directory for checking out the source code. mkdir breakpad && cd breakpad
Run the fetch
tool from depot_tools to download all the source repos. fetch breakpad
Make changes. Build and test your changes. For core code like processor use methods above. For linux/mac/windows, there are test targets in each project file.
Commit your changes to your local repo and upload them to the server. http://dev.chromium.org/developers/contributing-code e.g. git commit ... && git cl upload ...
You will be prompted for credential and a description.
At https://codereview.chromium.org/ you'll find your issue listed; click on it, and select Publish+Mail, and enter in the code reviewer and CC google-breakpad-dev@googlegroups.com
Visit https://chromium.googlesource.com/breakpad/breakpad/+/master/docs/