| commit | 417f5dbd0af9f96ca3e5faa99f41c064b89b40fd | [log] [tgz] |
|---|---|---|
| author | Jacob Hinton <jacohint@amazon.com> | Thu May 02 22:19:16 2024 |
| committer | Mike Frysinger <vapier@chromium.org> | Mon May 13 17:37:38 2024 |
| tree | 7bc74f6bdd68da80dcc8a65dcbdb1da8b529ae61 | |
| parent | 54986d34d4611983243f8401563ff022b649afbf [diff] |
preserve NT_FILE note converting md to core breakpad produced Minidumps have all the information needed to preserve the NT_FILE note that linux coredumps normally have, but are not currently included when converting using minidump-2-core. This adds a step to coredump generation to add the note to the coredump. This change allows for two improvements when loading coredumps into gdb: 1. for PIE code (default compilation now for gcc) gdb is now able to properly validate the PIE displacement and apply it to the debugging session, providing better stack trace quality. 2. gdb can now pick up so symbol files automatically without relying on the scripting normally recommended by google for breakpad where add-symbol-file is used to manually load symbols. Bug: https://crbug.com/google-breakpad/766 Change-Id: I8cb25246dce0ae3492eedd6d3a4efcf1783d414d Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5463435 Reviewed-by: Mike Frysinger <vapier@chromium.org>
Breakpad is a set of client and server components which implement a crash-reporting system.
First, download depot_tools and ensure that they’re in your PATH.
Create a new directory for checking out the source code (it must be named breakpad).
mkdir breakpad && cd breakpad
Run the fetch tool from depot_tools to download all the source repos.
fetch breakpad
cd src
Build the source.
./configure && make
You can also cd to another directory and run configure from there to build outside the source tree.
This will build the processor tools (src/processor/minidump_stackwalk, src/processor/minidump_dump, etc), and when building on Linux it will also build the client libraries and some tools (src/tools/linux/dump_syms/dump_syms, src/tools/linux/md2core/minidump-2-core, etc).
Optionally, run tests.
make check
Optionally, install the built libraries
make install
If you need to reconfigure your build be sure to run make distclean first.
To update an existing checkout to a newer revision, you can git pull as usual, but then you should run gclient sync to ensure that the dependent repos are up-to-date.
Follow the steps above to get the source and build it.
Make changes. Build and test your changes. For core code like processor use methods above. For linux/mac/windows, there are test targets in each project file.
Commit your changes to your local repo and upload them to the server. http://dev.chromium.org/developers/contributing-code e.g. git commit ... && git cl upload ... You will be prompted for credential and a description.
At https://chromium-review.googlesource.com/ you'll find your issue listed; click on it, then “Add reviewer”, and enter in the code reviewer. Depending on your settings, you may not see an email, but the reviewer has been notified with google-breakpad-dev@googlegroups.com always CC’d.