| commit | 41b6533e5f3dd7f0320ef58608ee32e8e4f132fb | [log] [tgz] |
|---|---|---|
| author | Mike Frysinger <vapier@chromium.org> | Wed Jan 15 04:41:57 2025 |
| committer | Mike Frysinger <vapier@chromium.org> | Fri Jan 17 00:01:41 2025 |
| tree | 1ceffb48ac283c8380175eb6407f3d84b972005c | |
| parent | feea0f7672e5e7ac33ebbf6acb13e580f8b6b136 [diff] |
use std::move with vector insertions
Coverity has started detecting places where variables are inserted into
a vector via a copy operation, and then not used anymore. Switch them
over to explicit std::move for quick performance improvements.
For example:
6405 MinidumpCrashpadInfo::AnnotationObject object = {annotation.type, name,
6406 value_data};
>>> CID 465406: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "object" is copied and then passed-by-reference as parameter to STL insertion
function "std::vector<google_breakpad::MinidumpCrashpadInfo::AnnotationObject,
std::allocator<google_breakpad::MinidumpCrashpadInfo::AnnotationObject> >::push_back(
std::vector<google_breakpad::MinidumpCrashpadInfo::AnnotationObject,
std::allocator<google_breakpad::MinidumpCrashpadInfo::AnnotationObject> >::value_type const &)",
when it could be moved instead.
6407 annotations_list->push_back(object);
Change-Id: I2d3b3a35296dad84853f4dc6690d64c81c92d582
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/6173183
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Breakpad is a set of client and server components which implement a crash-reporting system.
First, download depot_tools and ensure that they’re in your PATH.
Create a new directory for checking out the source code (it must be named breakpad).
mkdir breakpad && cd breakpad
Run the fetch tool from depot_tools to download all the source repos.
fetch breakpad
cd src
Build the source.
./configure && make
You can also cd to another directory and run configure from there to build outside the source tree.
This will build the processor tools (src/processor/minidump_stackwalk, src/processor/minidump_dump, etc), and when building on Linux it will also build the client libraries and some tools (src/tools/linux/dump_syms/dump_syms, src/tools/linux/md2core/minidump-2-core, etc).
Optionally, run tests.
make check
Optionally, install the built libraries
make install
If you need to reconfigure your build be sure to run make distclean first.
To update an existing checkout to a newer revision, you can git pull as usual, but then you should run gclient sync to ensure that the dependent repos are up-to-date.
Follow the steps above to get the source and build it.
Make changes. Build and test your changes. For core code like processor use methods above. For linux/mac/windows, there are test targets in each project file.
Commit your changes to your local repo and upload them to the server. http://dev.chromium.org/developers/contributing-code e.g. git commit ... && git cl upload ... You will be prompted for credential and a description.
At https://chromium-review.googlesource.com/ you'll find your issue listed; click on it, then “Add reviewer”, and enter in the code reviewer. Depending on your settings, you may not see an email, but the reviewer has been notified with google-breakpad-dev@googlegroups.com always CC’d.