|author||Brian Sheedy <firstname.lastname@example.org>||Tue Mar 16 17:39:32 2021|
|committer||Joshua Peraza <email@example.com>||Tue Mar 16 18:00:35 2021|
Revert "arm: Allow the first function to use linked register as return pc" This reverts commit f2b3ab5e0af48f59754a96f0dbe95e857ba1abbd. Reason for revert: Causes symbolization errors on ARM ChromeOS devices crbug.com/1182948. Original change's description: > arm: Allow the first function to use linked register as return pc > > For a crash at the function entry with corrupted PC, the caller's PC > could be lying in the link register. Using the PC from link register > would be more effective than blindly scanning the stack immediately. > > Change-Id: I51673b7298e70faeeab2bfa97075e3c4793f94bc > Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2678992 > Reviewed-by: Mike Frysinger <firstname.lastname@example.org> > Reviewed-by: Joshua Peraza <email@example.com> Bug: 1182948 Change-Id: I2818b35ab1fb99012919cccc0fb80368e456ca15 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2765164 Reviewed-by: Joshua Peraza <firstname.lastname@example.org>
Breakpad is a set of client and server components which implement a crash-reporting system.
First, download depot_tools and ensure that they’re in your
Create a new directory for checking out the source code (it must be named breakpad).
mkdir breakpad && cd breakpad
fetch tool from depot_tools to download all the source repos.
fetch breakpad cd src
Build the source.
./configure && make
You can also cd to another directory and run configure from there to build outside the source tree.
This will build the processor tools (
src/processor/minidump_dump, etc), and when building on Linux it will also build the client libraries and some tools (
Optionally, run tests.
Optionally, install the built libraries
If you need to reconfigure your build be sure to run
make distclean first.
To update an existing checkout to a newer revision, you can
git pull as usual, but then you should run
gclient sync to ensure that the dependent repos are up-to-date.
Follow the steps above to get the source and build it.
Make changes. Build and test your changes. For core code like processor use methods above. For linux/mac/windows, there are test targets in each project file.
Commit your changes to your local repo and upload them to the server. http://dev.chromium.org/developers/contributing-code e.g.
git commit ... && git cl upload ... You will be prompted for credential and a description.
At https://chromium-review.googlesource.com/ you'll find your issue listed; click on it, then “Add reviewer”, and enter in the code reviewer. Depending on your settings, you may not see an email, but the reviewer has been notified with email@example.com always CC’d.