commit 0291f06d41c77f083fbf9b3d808fa0452c71ee84
author Ivan Penkov <ivanpe@chromium.org> Mon Feb 01 02:17:42 2016
committer Mark Mentovai <mark@chromium.org> Tue Feb 02 20:48:26 2016
tree de88f09d583836ff99277f0e05ac716139174799
parent 528035ae4e0df78cd9e11a69a5ac78d05c56ff15

Remove use of deprecated CFURLCreateDataAndPropertiesFromResource function.

Original change (https://codereview.chromium.org/1527363003/) was failing
in CFReadStreamGetBuffer() call, so changed to CFReadStreamRead() to be
more conservative.

Patch provided by Scott Hancher.

BUG=
R=mark@chromium.org

Review URL: https://codereview.chromium.org/1637433003 .

src/client/mac/handler/minidump_generator.cc

diff --git a/src/client/mac/handler/minidump_generator.cc b/src/client/mac/handler/minidump_generator.cc
index 7d6e81d..5340656 100644
--- a/src/client/mac/handler/minidump_generator.cc
+++ b/src/client/mac/handler/minidump_generator.cc
@@ -142,12 +142,25 @@
     CFRelease(read_stream);
     return;
   }
-  CFDataRef data = NULL;
-  CFIndex num_bytes_read = 0;
-  const UInt8 *data_bytes =
-    CFReadStreamGetBuffer(read_stream, 0, &num_bytes_read);
-  if (data_bytes) {
-    data = CFDataCreate(NULL, data_bytes, num_bytes_read);
+  CFMutableDataRef data = NULL;
+  while (true) {
+    // Actual data file tests: Mac at 480 bytes and iOS at 413 bytes.
+    const CFIndex kMaxBufferLength = 1024;
+    UInt8 data_bytes[kMaxBufferLength];
+    CFIndex num_bytes_read =
+      CFReadStreamRead(read_stream, data_bytes, kMaxBufferLength);
+    if (num_bytes_read < 0) {
+      if (data) {
+        CFRelease(data);
+        data = NULL;
+      }
+      break;
+    } else if (num_bytes_read == 0) {
+      break;
+    } else if (!data) {
+      data = CFDataCreateMutable(NULL, 0);
+    }
+    CFDataAppendBytes(data, data_bytes, num_bytes_read);
   }
   CFReadStreamClose(read_stream);
   CFRelease(read_stream);