|author||Jason Jeremy Iman <email@example.com>||Wed Jan 25 04:28:31 2023|
|committer||Joshua Peraza <firstname.lastname@example.org>||Fri Jan 27 20:36:21 2023|
LibcurlWrapper uses curl_global_cleanup LibcurlWrapper is missing a curl_global_cleanup causing a memory leak. The curl_global_init is called automatically when calling curl_easy_init without first doing curl_global_init. BUG=chromium:1405410 TEST=units with asan Change-Id: I4982fd5265b0df91076ed428f1134a681a7f28c6 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/4189295 Reviewed-by: Joshua Peraza <email@example.com>
Breakpad is a set of client and server components which implement a crash-reporting system.
First, download depot_tools and ensure that they’re in your
Create a new directory for checking out the source code (it must be named breakpad).
mkdir breakpad && cd breakpad
fetch tool from depot_tools to download all the source repos.
fetch breakpad cd src
Build the source.
./configure && make
You can also cd to another directory and run configure from there to build outside the source tree.
This will build the processor tools (
src/processor/minidump_dump, etc), and when building on Linux it will also build the client libraries and some tools (
Optionally, run tests.
Optionally, install the built libraries
If you need to reconfigure your build be sure to run
make distclean first.
To update an existing checkout to a newer revision, you can
git pull as usual, but then you should run
gclient sync to ensure that the dependent repos are up-to-date.
Follow the steps above to get the source and build it.
Make changes. Build and test your changes. For core code like processor use methods above. For linux/mac/windows, there are test targets in each project file.
Commit your changes to your local repo and upload them to the server. http://dev.chromium.org/developers/contributing-code e.g.
git commit ... && git cl upload ... You will be prompted for credential and a description.
At https://chromium-review.googlesource.com/ you'll find your issue listed; click on it, then “Add reviewer”, and enter in the code reviewer. Depending on your settings, you may not see an email, but the reviewer has been notified with firstname.lastname@example.org always CC’d.