Google Git
Sign in
chromium/build/1b75f5dea5f0c57fb22ee8f99c20ae34429e50ba
commit
1b75f5dea5f0c57fb22ee8f99c20ae34429e50ba
[log]
author
Ryosuke Miyake <rysk@google.com>
Wed Aug 12 07:48:43 2026
committer
LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>
Wed Aug 12 07:48:43 2026
tree
44bef15f739093a5241e6bf548c172c05dea1360
parent
f790a8bbea18ca0cfb3cc2af4755438c20fe4d00 [diff]
siso: clarify error prefixes on deps validation failures

When checkDeps fails during post-step dependency validation, error
messages were previously prefixed with:
- "error in /showIncludes:" for deps=msvc
- "error in depfile %q:" for deps=gcc

Prefixing MSVC validation failures with "error in /showIncludes:" was
misleading because the compiler invocation with /showIncludes completed
successfully. The prefix falsely suggested a compiler execution failure
rather than an undeclared dependency in the build graph.

This CL updates the error prefixes for consistency and clarity:
- deps_msvc: "error in MSVC deps check: %w"
- deps_gcc: "error in GCC deps check with depfile %q: %w"

Bug: 541969064
Change-Id: I2aa6e2a5f42a119e2b49535728d25a0b2b82a9e5
Reviewed-on: https://chromium-review.googlesource.com/c/build/+/8246760
Commit-Queue: Ryosuke Miyake <rysk@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
2 files changed
tree: 44bef15f739093a5241e6bf548c172c05dea1360
  1. bench/
  2. gong/
  3. hashigo/
  4. infra/
  5. kajiya/
  6. kzipinfo/
  7. remote-apis/
  8. runmc/
  9. siso/
  10. .gitignore
  11. .golangci.yml
  12. .style.yapf
  13. BUILD_OWNERS
  14. BUILD_TEAM_OWNERS
  15. CONTRIBUTING.md
  16. LICENSE
  17. OWNERS
  18. PRESUBMIT.py
  19. README.md
  20. WATCHLISTS
README.md

build.git repository

This repository contains tools developed and owned by the Chrome Build Team.

Quick start

The steps for getting the code are:

  1. Install depot_tools
  2. Run git clone https://chromium.googlesource.com/build

We use the standard Go module workflow to work on our projects.

Links