siso: fix StepMetric.RunTime to include postproc for remoteexec

For local exec and remote cache, RunTime already included postproc.

Hence for remote exec to not include it was inconsistent, and also goes
against the intention of RunTime being "the total duration of the action
execution, including overhead such as uploading / downloading files".

A previous CL introduced a `-run` span for remoteexec, but it would have
to overlap the last attempt + postproc.
Rather than trying to contort the last attempt to be parented to the
`-run` span, let all the `-attempt` spans be siblings, have another
`-postproc` sibling span.

Then, the responsibility for deciding `-run` is pushed to where RunTime
is projected.

Bug: b/520207778
Change-Id: Ia3f07f1ceef3733c37cd8341752a99e16a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/build/+/8160704
Commit-Queue: Richard Wang <richardwa@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
3 files changed
tree: 446c701ec395830a9bc75901f1d0a021aa3c3454
  1. bench/
  2. gong/
  3. hashigo/
  4. infra/
  5. kajiya/
  6. kzipinfo/
  7. remote-apis/
  8. runmc/
  9. siso/
  10. .gitignore
  11. .golangci.yml
  12. .style.yapf
  13. BUILD_OWNERS
  14. BUILD_TEAM_OWNERS
  15. CONTRIBUTING.md
  16. LICENSE
  17. OWNERS
  18. PRESUBMIT.py
  19. README.md
  20. WATCHLISTS
README.md

build.git repository

This repository contains tools developed and owned by the Chrome Build Team.

Quick start

The steps for getting the code are:

  1. Install depot_tools
  2. Run git clone https://chromium.googlesource.com/build

We use the standard Go module workflow to work on our projects.

Links