Google Git
Sign in
chromium/build/d6a79eb9d48d4e222776eefd8c9ccb83798a052b
commit
d6a79eb9d48d4e222776eefd8c9ccb83798a052b
[log]
author
Ryosuke Miyake <rysk@google.com>
Tue Aug 04 04:02:09 2026
committer
LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>
Tue Aug 04 04:02:09 2026
tree
b401fad65c34cc2ec98008ce996449e3848f50b4
parent
93a9ffb5b42957f52e4f34e802d8f860a1da8a2a [diff]
siso: remove obsolete /showincludes basename matching in DepsAfterRun

This workaround was originally implemented for an upstream clang-cl issue where /showincludes failed to report canonical header paths (https://github.com/llvm/llvm-project/issues/58726, b/294927170).

Because the LLVM issue has been fixed upstream, this basename matching loop is no longer necessary and can be cleanly removed.

Removing this also resolves false-positive missing dependency failures on Windows when SISO_EXPERIMENTS=fail-on-bad-deps is enabled, as scandeps inputs will no longer collide with compiler dependency tracking via basename matching.

Bug: 541968721, 539781437
Change-Id: I77703853e232cbf43fc132a9dd8d2d6300d3855e
Reviewed-on: https://chromium-review.googlesource.com/c/build/+/8176008
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Ryosuke Miyake <rysk@google.com>
3 files changed
tree: b401fad65c34cc2ec98008ce996449e3848f50b4
  1. bench/
  2. gong/
  3. hashigo/
  4. infra/
  5. kajiya/
  6. kzipinfo/
  7. remote-apis/
  8. runmc/
  9. siso/
  10. .gitignore
  11. .golangci.yml
  12. .style.yapf
  13. BUILD_OWNERS
  14. BUILD_TEAM_OWNERS
  15. CONTRIBUTING.md
  16. LICENSE
  17. OWNERS
  18. PRESUBMIT.py
  19. README.md
  20. WATCHLISTS
README.md

build.git repository

This repository contains tools developed and owned by the Chrome Build Team.

Quick start

The steps for getting the code are:

  1. Install depot_tools
  2. Run git clone https://chromium.googlesource.com/build

We use the standard Go module workflow to work on our projects.

Links