| commit | 2671b653f33188ee93329809fd3d4957f8798638 | [log] [tgz] |
|---|---|---|
| author | Dave Tu <dtu@chromium.org> | Thu Nov 09 20:27:37 2017 |
| committer | Commit Bot <commit-bot@chromium.org> | Thu Nov 09 21:14:18 2017 |
| tree | 01983e3f658c13faa9515690202896fbb448b9cd | |
| parent | b3971d87403ab246c308c7e9d0628cc6ab47b2a4 [diff] |
[pinpoint] AsDict() results_values fixes. Fixes from https://chromium-review.googlesource.com/c/catapult/+/758051 Because I landed that without testing it first, and Job doesn't have full unit test coverage yet. Bug: catapult:#4025 Change-Id: Ic6dc0d5ac88711bc49562e19486c269bf5acf023 Reviewed-on: https://chromium-review.googlesource.com/761424 Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: David Tu <dtu@chromium.org>
diff --git a/dashboard/dashboard/pinpoint/models/job.py b/dashboard/dashboard/pinpoint/models/job.py index 8ebe8a6..7615b5b 100644 --- a/dashboard/dashboard/pinpoint/models/job.py +++ b/dashboard/dashboard/pinpoint/models/job.py
@@ -355,8 +355,9 @@ executions = _ExecutionsPerQuest(self._attempts[change]) change_result_values = [] for quest in self._quests: - quest_result_values = [itertools.chain.from_iterable( - execution for execution in executions[quest])] + quest_result_values = list(itertools.chain.from_iterable( + execution.result_values for execution in executions[quest] + if execution.completed)) change_result_values.append(quest_result_values) result_values.append(change_result_values)