commit 61c11002976bf6d9a0677d511280c6efa5c5ba40
author Nidhi Jaju <nidhijaju@google.com> Wed Jul 15 02:39:18 2020
committer Commit Bot <commit-bot@chromium.org> Wed Jul 15 02:39:18 2020
tree 6458a9c03b89322c387d85dd3fdb19050690eca5
parent fe63b46e4dd254ac4986617ec8e0b519d7cc5113

[M85] Remove ServiceWorkerObserver from IsolatedPrerenderTabHelper

This CL replaces the use of IsolatedPrerenderServiceWorkerObserver::
IsServiceWorkerRegisteredForOrigin() by directly calling ServiceWorker
Context::HasRegistrationForOrigin() in IsolatedPrerenderTabHelper::
CheckEligibilityOfURL. This can be done because this method
is called on the UI thread. By using HasRegistrationForOrigin(), we are
able to use the already existing |registered_origins_|, as it is not
necessary to retrieve all service registrations just to confirm if a
service worker is registered for a particular origin. Furthermore,
the IsolatedPrerenderServiceWorkerObserver class is also removed as it
is not needed anymore.

The motivation of this change is to eliminate unnecessary memory
allocations and data conversions GetAllOriginsInfo() performs
(see [1] for details). When the browser has many service worker
registrations for different origins, these allocations/conversions
have considerable performance impact.

[1] https://docs.google.com/document/d/1iaQGQzovFVL3LxDiyIvVgEUFWMhzrXpdf_6TmuwIICA

(cherry picked from commit d4393884b45ae28350b132613d026f6d18ad1dda)

Bug: 807440
Change-Id: I6081df48fd6b02850ca8276923134ee7c821b92a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259677
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Nidhi Jaju <nidhijaju@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#782802}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297007
Cr-Commit-Position: refs/branch-heads/4183@{#536}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}