tree 8651fcc9f0eaab85fa9d8532b4e06ed4b807e420
parent 16cb7c8c4f59693bed364e9a30c467d7ac9f6482
author Stephen McGruer <smcgruer@chromium.org> 1562592085 +0000
committer Commit Bot <commit-bot@chromium.org> 1562592085 +0000

Properly test !CSSPaintAPIArguments in CSSPaintValueTest

Previously all the tests assumed that CSSPaintAPIArguments was on, which
was covering up a bug where OffMainThreadCSSPaint would create a
deferred image even though the generator wasn't ready (because
ParseInputArguments would pass due to !CSSPaintAPIArguments). This CL
fixes the tests to actually test all combinations, and fixes the bug by
extracting the generator-ready check outside of ParseInputArguments.

Bug: None
Change-Id: I6789cf24b7efa6035a88990082a857f24ccafbb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689953
Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675214}