commit | 08baca7729d4a91e5cf693bd0eda13d80b8b7a5a | [log] [tgz] |
---|---|---|
author | Hiroki Nakagawa <nhiroki@chromium.org> | Wed Nov 21 12:31:18 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Nov 21 12:31:18 2018 |
tree | 4df3a71b7deddd3a0a7f4b614a8cf9163ccd1c6e | |
parent | b1101c25681c2051acda608febe69fa2913291eb [diff] |
Worker: Throw an original Error on importScripts() failure Before this CL, when a failure on importScripts() happens, WorkerOrWorkletScriptController::RethrowExceptionFromImportedScript() creates a new Error and throws it instead of an original Error. This fails web platform tests: https://wpt.fyi/results/workers/interfaces/WorkerUtils/importScripts/004.html?label=stable&aligned https://wpt.fyi/results/workers/interfaces/WorkerUtils/importScripts/006.html?label=stable&aligned This CL makes the function throw the original Error. In addition, this CL changes ErrorEvent::CreateSanitizedError() to create a sanitized error with a null error object instead of an empty error object. This is because the HTML spec requires the error object for scripts whose errors are muted must be null, and ExceptionState::RethrowV8Exception() called from RethrowExceptionFromImportedScript() doesn't throw an exception when its error object is empty. Bug: 651778, 655458 Change-Id: I67a91879b4a9fa3fd521797394fe35de89634b7a Reviewed-on: https://chromium-review.googlesource.com/c/1343465 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#610011}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .