[devtools] Add filename to Page.downloadWillBegin

Chromium (and browsers in general) have logic about how to name a
downloaded file based on a number of factors: `Content-Disposition`
HTTP headers, the `download` attribute of an Anchor tag, detected
MimeType, etc. When testing and understanding what the browser
downloaded, it's helpful to know what the download was named on
disk.

Previously, there was no way to tie a Download GUID (which appears in
the `Page.downloadWillBegin` and `Page.downloadProgress` events) to the
actual filename on disk.

This changeset fixes that by exposing an approximated filename in the
Page.downloadWillBegin event.

NB: This does not fully encompass all the browser-level renaming
possibilities, but it is a near approximation of what is likely to
end up on disk. Certain extensions and mimetypes may yield different
final names; likewise, downloaded files with clashing names will not
include the incrementing counter number that users would see in Chrome
when downloading files with clashing names.

Test: Ran the following targets: `http/tests/inspector-protocol/{browser,page}`
Bug: chromium:1076697
Change-Id: I48e364b1696627ef19ec25049838f88d085aba2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174778
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766623}
7 files changed
tree: 8245e80e77f11482eca2a9a84fe0fb88c69b93d3
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.