Google Git
Sign in
chromium / chromium / src.git / 200abd62a22a433cc155d6718c2718693654aa61
commit200abd62a22a433cc155d6718c2718693654aa61[log] [tgz]
authorkylechar <kylechar@chromium.org>Thu Apr 04 22:57:13 2019
committerCommit Bot <commit-bot@chromium.org>Thu Apr 04 22:57:13 2019
tree2dc09abb10a0676ae58d83ace6eb5913ea948610
parent0ddf56ea95849b6ac267a2d5ebb31d30968db78a [diff]
Make VizCompositorThread TYPE_DEFAULT on Windows.

When Chrome is launched by a service in a console session, which seems
to how Chrome is launched from some automation frameworks, creating a
message only window for MessagePumpForUI fails in the GPU process. As a
result VizCompositorThread fails to run any tasks and nothing is ever
drawn, see https://crbug.com/942023.

The display compositor thread was originally made TYPE_UI on Windows in
https://crrev.com/c/1025954. This was to allow using a child HWND
created in the GPU process for software composited output. That code was
deleted in https://crrev.com/c/1450399 so the thread shouldn't need to
be TYPE_UI anymore.

Bug: 942023
Change-Id: I2a7dbf46a3a772b5ab1a9a20367d3e7f08116cbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549763
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647967}
1 file changed
tree: 2dc09abb10a0676ae58d83ace6eb5913ea948610
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .