Google Git
Sign in
chromium / chromium / src.git / 3476cb25a4239c6877beb369865985855339c2b8
commit3476cb25a4239c6877beb369865985855339c2b8[log] [tgz]
authorTetsui Ohkubo <tetsui@chromium.org>Fri Jan 11 01:34:25 2019
committerCommit Bot <commit-bot@chromium.org>Fri Jan 11 01:34:25 2019
tree7aee4d7f5ab01339e70fad621f95391b9b37af9e
parent0b15d057e7dacd7e14d2ff3b0308c1cc2b706695 [diff]
NotificationViewMD: Validate after ToggleExpanded

NotificationViewMD::ButtonPressed() crashes when a notification popup is
expanded and that causes the popup to be removed. (It happens when
there's not enough screen space and the topmost notification is
expanded.)

This CL checks if |this| is still valid after ToggleExpanded by using
WeakPtr. Also it removes old workaround for the same issue that wasn't
working. (Added in https://crrev.com/114503004)

TEST=NotificationViewMD.TestDeleteOnToggleExpanded
BUG=918933

Change-Id: I9e1290112d6eaa2ab7155eb291764cd38e854f7e
Reviewed-on: https://chromium-review.googlesource.com/c/1400431
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621850}
3 files changed
tree: 7aee4d7f5ab01339e70fad621f95391b9b37af9e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .